-
Notifications
You must be signed in to change notification settings - Fork 225
Fix illegal instructions failures in examples #3012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like it wasn't enough to fix the problem unfortunately:
There's a few more PRs I merged with the same pattern of using Plus this one which defines a constructor in a header - not sure if relevant as it was there before already: And this one which added I think a valgrind job would be really helpful here to validate that these are actually the culprits. |
@david-cortes-intel yes, but #2996, #2997, #2998 are in I will dig further - planning to reproduce locally. |
@david-cortes-intel Yes, that helps very much. Thank you! Didn't understood that during the call. |
/intelci: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps these patterns could be added as coding guidelines for implementation of algorithms in the docs.
The implementations of the methods that could potentially be the cause of illegal instructions issues in the examples are moved away from header files.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing