Skip to content

Fix illegal instructions failures in examples #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

Vika-F
Copy link
Contributor

@Vika-F Vika-F commented Dec 9, 2024

The implementations of the methods that could potentially be the cause of illegal instructions issues in the examples are moved away from header files.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.

@Vika-F Vika-F added the bug label Dec 9, 2024
@david-cortes-intel
Copy link
Contributor

Looks like it wasn't enough to fix the problem unfortunately:

16:52:48 FAILED		svm_two_class_thunder_csr_batch with errno 132
.ci/scripts/test.sh: line 248: 46928 Illegal instruction     (core dumped) ${run_command} > "${e}".res 2>&1

There's a few more PRs I merged with the same pattern of using = delete in header files:
https://github.com/uxlfoundation/oneDAL/pull/2998/files
https://github.com/uxlfoundation/oneDAL/pull/2997/files
https://github.com/uxlfoundation/oneDAL/pull/2996/files

Plus this one which defines a constructor in a header - not sure if relevant as it was there before already:
https://github.com/uxlfoundation/oneDAL/pull/2994/files

And this one which added = default in headers:
https://github.com/uxlfoundation/oneDAL/pull/3006/files

I think a valgrind job would be really helpful here to validate that these are actually the culprits.

@Vika-F
Copy link
Contributor Author

Vika-F commented Dec 10, 2024

@david-cortes-intel yes, but #2996, #2997, #2998 are in cpp/oneapi/dal, which should not have those problems. Only cpp/daal build sub-system with it's 'cpu' template is fragile in terms of illegal instructions.
The fix for the cases from #3006 is also included into this PR.

I will dig further - planning to reproduce locally.

@david-cortes-intel
Copy link
Contributor

In case it helps, the breakage seems to have started with this commit:
#2991

This PR has CI jobs with reproducers - succeds before that PR, fails after adding it:
#3014

@Vika-F
Copy link
Contributor Author

Vika-F commented Dec 10, 2024

In case it helps, the breakage seems to have started with this commit: #2991

This PR has CI jobs with reproducers - succeds before that PR, fails after adding it: #3014

@david-cortes-intel Yes, that helps very much. Thank you! Didn't understood that during the call.

@Vika-F
Copy link
Contributor Author

Vika-F commented Dec 11, 2024

/intelci: run

Copy link
Contributor

@david-cortes-intel david-cortes-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps these patterns could be added as coding guidelines for implementation of algorithms in the docs.

@Vika-F Vika-F merged commit f52a129 into uxlfoundation:main Dec 11, 2024
20 of 21 checks passed
@Vika-F Vika-F deleted the dev/illegal_instr branch July 15, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants