Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove outdated todos in tests #3023

Merged
merged 2 commits into from
Dec 20, 2024
Merged

test: remove outdated todos in tests #3023

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a88df07
test: remove outdated todos in tests
ethanglaser Dec 13, 2024
4dfa9f8
restore kmeans
ethanglaser Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cpp/oneapi/dal/algo/kmeans/test/batch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,6 @@ TEMPLATE_LIST_TEST_M(kmeans_batch_test,
"kmeans block test",
"[kmeans][batch][nightly][block]",
kmeans_types) {
// This test is not stable on CPU
// TODO: Remove the following `SKIP_IF` once stability problem is resolved
SKIP_IF(this->get_policy().is_cpu());
SKIP_IF(this->is_sparse_method());
ethanglaser marked this conversation as resolved.
Show resolved Hide resolved
SKIP_IF(this->not_float64_friendly());
this->check_on_large_data_with_one_cluster();
Expand Down
6 changes: 0 additions & 6 deletions cpp/oneapi/dal/backend/primitives/blas/test/gemv_dpc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,6 @@ class gemv_test : public te::float_algo_fixture<std::tuple_element_t<0, Param>>
using gemv_types = COMBINE_TYPES((float, double), (c_order, f_order));

TEMPLATE_LIST_TEST_M(gemv_test, "ones matrix gemv on small sizes", "[gemv][small]", gemv_types) {
// TODO: ensure gemv issue is resolved and remove skip
SKIP_IF(true);

// DPC++ GEMV from micro MKL libs is not supported on GPU
SKIP_IF(this->get_policy().is_cpu());

Expand All @@ -162,9 +159,6 @@ TEMPLATE_LIST_TEST_M(gemv_test, "ones matrix gemv on small sizes", "[gemv][small
}

TEMPLATE_LIST_TEST_M(gemv_test, "ones matrix gemv on medium sizes", "[gemv][small]", gemv_types) {
// TODO: ensure gemv issue is resolved and remove skip
SKIP_IF(true);

// DPC++ GEMV from micro MKL libs is not supported on GPU
SKIP_IF(this->get_policy().is_cpu());

Expand Down
4 changes: 0 additions & 4 deletions cpp/oneapi/dal/backend/primitives/selection/test/select_flagged_dpc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,6 @@ TEMPLATE_LIST_TEST_M(select_flagged_test,
"select flagged",
"[select flagged]",
select_flagged_types) {
// TODO: Fix problem with incorrect number of total sum on CPU
SKIP_IF(this->get_policy().is_cpu());
SKIP_IF(this->not_float64_friendly());
std::int64_t elem_count = GENERATE_COPY(2, 15, 16000);

Expand All @@ -240,8 +238,6 @@ TEMPLATE_LIST_TEST_M(select_flagged_index_test,
"select flagged index",
"[select flagged]",
select_flagged_index_types) {
// TODO: Fix problem with incorrect number of total sum on CPU
SKIP_IF(this->get_policy().is_cpu());
SKIP_IF(this->not_float64_friendly());
std::int64_t elem_count = GENERATE_COPY(2, 15, 16000);

Expand Down
1 change: 0 additions & 1 deletion cpp/oneapi/dal/backend/primitives/selection/test/select_indexed_rows_dpc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ TEMPLATE_LIST_TEST_M(selection_by_rows_test,
"selection indexed rows",
"[block select][small]",
selection_types) {
SKIP_IF(true);
SKIP_IF(this->not_float64_friendly());
this->generate();
this->check_full();
Expand Down
Loading