Add optionaly the add_sycl_to_target cmake integration to blas and rng domains#101
Merged
mmeterel merged 6 commits intouxlfoundation:developfrom Aug 23, 2021
Merged
Conversation
mkrainiuk
reviewed
Jun 16, 2021
Contributor
mkrainiuk
left a comment
mkrainiuk
left a comment
There was a problem hiding this comment.
Thank you for the PR! I have one comment about potential improvement for better user experience.
mmeterel
reviewed
Jun 18, 2021
mkrainiuk
reviewed
Jul 13, 2021
mkrainiuk
reviewed
Aug 2, 2021
mkrainiuk
reviewed
Aug 2, 2021
mkrainiuk
approved these changes
Aug 3, 2021
mmeterel
reviewed
Aug 12, 2021
sbalint98
force-pushed
the
ustream-cmake
branch
from
fb8d585 to
277ce8a
Compare
mmeterel
approved these changes
Aug 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for using the
add_sycl_to_targetcmake integration, which is widely used by other SYCL implementations. This is necessary for enabling hipSYCL to work with oneMKL see #99Checklist