Add abstraction for invocation of interop_task#103
Merged
mmeterel merged 2 commits intouxlfoundation:developfrom Jun 23, 2021
Merged
Add abstraction for invocation of interop_task#103mmeterel merged 2 commits intouxlfoundation:developfrom
mmeterel merged 2 commits intouxlfoundation:developfrom
Conversation
mkrainiuk
approved these changes
Jun 16, 2021
Contributor
mkrainiuk
left a comment
mkrainiuk
left a comment
There was a problem hiding this comment.
Thank you for PR! Looks good to me.
Contributor
|
Looks good to me. |
mmeterel
approved these changes
Jun 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR abstracts away the
interop_taskcalls inside the cuBLAS functions. This approach is intended to be very similar to the one for the MKLcpu functions. Putting the actual call inside thecublas_task.hppallows us to cleanly define an alternative if we want to use a different interface.This PR also changes the interface for
CublasScopedContextHandler. Theinterop_handleris passed with the constructor; this enables changing theCublasScopedContextHandlerimplementation to be easily switched among different SYCL implementations.For example, in the case of hipSYCL, this PR enables the following pattern: https://github.com/sbalint98/oneMKL/blob/90598195961ce6cfa4c4a6723176611a2a5487ea/src/blas/backends/cublas/cublas_task.hpp
related to #99
All Submissions