Use appropiately qualified names in blas and rng#105
Merged
mmeterel merged 5 commits intouxlfoundation:developfrom Aug 19, 2021
Merged
Use appropiately qualified names in blas and rng#105mmeterel merged 5 commits intouxlfoundation:developfrom
mmeterel merged 5 commits intouxlfoundation:developfrom
Conversation
mkrainiuk
reviewed
Jun 16, 2021
Contributor
mkrainiuk
left a comment
mkrainiuk
left a comment
There was a problem hiding this comment.
Thank you for PR! I have one comment regarding these changes.
mmeterel
reviewed
Jun 18, 2021
mkrainiuk
reviewed
Jul 20, 2021
mkrainiuk
approved these changes
Jul 31, 2021
mmeterel
reviewed
Aug 12, 2021
Contributor
|
@sbalint98 Could you please resolve the conflicts? |
sbalint98
force-pushed
the
ustream-qualifications
branch
from
64e6fa2 to
b0c8511
Compare
aelizaro
approved these changes
Aug 19, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some types in the blas and rng domain did not have properly qualified names. This has caused trouble when using different SYCL implementations. This PR fixes this for these two domains.
related to #99
All Submissions