Skip to content

Enabling Unified Shared Memory (USM) interfaces#18

Merged
mmeterel merged 5 commits intouxlfoundation:masterfrom
mmeterel:Adding_USM_interfaces_tests
May 29, 2020
Merged

Enabling Unified Shared Memory (USM) interfaces#18
mmeterel merged 5 commits intouxlfoundation:masterfrom
mmeterel:Adding_USM_interfaces_tests

Conversation

@mmeterel
Copy link
Contributor

This PR is adding Unified Shared Memory interfaces, functional tests and documentation for BLAS domain.

All unit tests are passing both locally and through CI.

USM interfaces are part of latest oneAPI spec (0.7)

@mmeterel mmeterel requested review from mkrainiuk and petercad May 21, 2020 19:56
@mmeterel
Copy link
Contributor Author

/intelci: run

Copy link

@petercad petercad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mmeterel, thanks for the PR. Overall, looks good -- just some small things here and there.

@jasukhar
Copy link
Contributor

/intelci: rerun

1 similar comment
@mmeterel
Copy link
Contributor Author

/intelci: rerun

@mmeterel
Copy link
Contributor Author

Hi @petercad

Thanks a lot for your valuable feedback. I believe I addressed all your comments. Please let me know if you have any further feedback.

@mmeterel
Copy link
Contributor Author

mmeterel commented May 27, 2020

/intelci: run

@mmeterel
Copy link
Contributor Author

/intelci: restart

@mmeterel
Copy link
Contributor Author

/intelci: run

Copy link

@petercad petercad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @mmeterel -- looks OK to merge to me.

@mmeterel
Copy link
Contributor Author

/intelci: run

1 similar comment
@mmeterel
Copy link
Contributor Author

/intelci: run

@mmeterel
Copy link
Contributor Author

/intelci: restart

@mmeterel
Copy link
Contributor Author

/intelci: run

@mmeterel
Copy link
Contributor Author

/intelci: restart

@mmeterel
Copy link
Contributor Author

Hi @mkrainiuk Thanks for the review. I have addressed your feedback. Pls let me know if you have any other reviews.

@mmeterel
Copy link
Contributor Author

/intelci: restart

@mmeterel
Copy link
Contributor Author

/intelci: run

@mmeterel mmeterel requested a review from NadyaTen May 28, 2020 22:32
@mmeterel
Copy link
Contributor Author

/intelci: run

@mmeterel
Copy link
Contributor Author

/intelci: restart

2 similar comments
@mmeterel
Copy link
Contributor Author

/intelci: restart

@mmeterel
Copy link
Contributor Author

/intelci: restart

@mmeterel
Copy link
Contributor Author

/intelci: run

@mmeterel mmeterel merged commit 98b817d into uxlfoundation:master May 29, 2020
@mmeterel mmeterel deleted the Adding_USM_interfaces_tests branch September 16, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants