Adding Intel LLVM support for rocRAND backend by TejaX-Alaghari · Pull Request #218 · uxlfoundation/oneMath

TejaX-Alaghari · 2022-08-01T12:39:23Z

Description

This PR is intended to extend the HIP backend of RNG domain, which is currently supported for hipSYCL compiler to Intel’s LLVM compiler.

Added the build config for rocRAND and API launch with

All Submissions

Have you formatted the code using clang-format?

New features

Have you provided motivation for adding a new feature?

test_log.txt

mmeterel · 2022-08-10T17:02:43Z

@TejaX-Alaghari Thanks for the PR. Similar comments from #189 applies here as well. Can we first focus on #189 and then apply the similar updates to this PR as well?

aelizaro

@TejaX-Alaghari, thank you for the PR! I have only 1 major question about engine passed to lambda by reference and several minor question.

Also, I see that Gaussian distribution tests failed for USM, do you know the root cause?

CMakeLists.txt

aelizaro · 2022-09-27T13:56:45Z

cmake/FindrocRAND.cmake

@@ -0,0 +1,46 @@
+#--===============================================================================
+# Copyright 2020-2022 Intel Corporation


Minor: Not sure about copyright

If this is a new file, the copyright should contain only the year 2022.

src/rng/backends/rocrand/rocrand_common.hpp

src/rng/backends/rocrand/rocrand_helper.hpp

…y with hipSYCL

aelizaro

Looks good to me, are all issues in tests addressed? (there were some failures in the attached log)

TejaX-Alaghari · 2022-10-18T00:20:38Z

Looks good to me, are all issues in tests addressed? (there were some failures in the attached log)

The failures of these skip_ahead cases is a known issue in rocRAND and has been mentioned in this oneMKL PR (ref Note2).

TejaX-Alaghari · 2022-10-19T05:26:54Z

@vmalia @mkrainiuk Could you please review this PR and share your feedback as well.

vmalia · 2022-10-20T21:38:24Z

cmake/FindrocRAND.cmake

@@ -0,0 +1,46 @@
+#--===============================================================================
+# Copyright 2020-2022 Intel Corporation


If this is a new file, the copyright should contain only the year 2022.

cmake/FindrocRAND.cmake

vmalia · 2022-10-20T21:46:09Z

src/rng/backends/rocrand/CMakeLists.txt

-)
+target_include_directories(
+  ${LIB_OBJ} PRIVATE ${PROJECT_SOURCE_DIR}/include ${PROJECT_SOURCE_DIR}/src
+                     ${CMAKE_BINARY_DIR}/bin ${MKL_INCLUDE})


There are many whitespace changes in CMake files including copyright and cmake code. Can you please share why we are making those changes?

We've observed that the format of this CMake file was not proper when compared with the other CMake files.
Hence we've ran the cmake-format tool on this file.

If you have any suggestion or recommendation on handling CMake file formats for oneMKL, do share with us.

I see, I think it is a great idea. @mkrainiuk do you think it would help us to investigate this tool and add it to Contribution guidelines just like clang-format?

Yes, this is a good idea to improve CMake file format too.

TejaX-Alaghari · 2022-11-01T00:00:30Z

@aelizaro and @vmalia , following the recent commit to cuRAND backend, I've added support for handling kernel launch with hipSYCL and LLVM's host_task separately.

Requesting for review and merging the PR.

TejaX-Alaghari · 2022-11-01T01:09:14Z

@aelizaro and @vmalia, thanks for all the suggestions and reviews.
@mkrainiuk, requesting for review.

…d_task.hpp

mkrainiuk

Thank you for the PR, changes look good to me.

mmeterel assigned aelizaro Sep 14, 2022

mmeterel requested review from aelizaro and mkrainiuk September 21, 2022 16:00

mmeterel mentioned this pull request Sep 21, 2022

Adding rocBLAS support for BLAS domain through Intel DPCPP compiler with HIP backend support #189

Merged

4 tasks

TejaX-Alaghari force-pushed the rocrand_hip_support branch from cf4c071 to 7d8fdec Compare September 26, 2022 15:46

aelizaro reviewed Sep 27, 2022

View reviewed changes

Teja Alaghari and others added 5 commits October 14, 2022 04:07

Adding Intel LLVM support for rocRAND backend

1ac0324

Adding compiler config for HIP backend of Intel LLVM

dd8a9f9

Adjusting format and adding HIP_TARGETS

b3b4208

Reverted the ext_oneapi_hip backend namespace to hip for compatibilit…

cf9732c

…y with hipSYCL

Updated hip dependency for rocRAND

a1d121b

TejaX-Alaghari force-pushed the rocrand_hip_support branch from f203691 to a1d121b Compare October 14, 2022 14:28

aelizaro reviewed Oct 17, 2022

View reviewed changes

aelizaro approved these changes Oct 18, 2022

View reviewed changes

vmalia reviewed Oct 20, 2022

View reviewed changes

TejaX-Alaghari and others added 4 commits October 21, 2022 11:31

Merge branch 'oneapi-src:develop' into rocrand_hip_support

cd5f057

Adjusted the license year for FindrocRAND

895e25e

Merge branch 'oneapi-src:develop' into rocrand_hip_support

27e8682

Added helper functions to incorporate hipSYCL and LLVM's kernel launch

2c73eb6

TejaX-Alaghari force-pushed the rocrand_hip_support branch from 4012172 to 2c73eb6 Compare October 31, 2022 23:55

vmalia approved these changes Nov 1, 2022

View reviewed changes

Deleted rocrand_common.hpp as its functionality is replaced by rocran…

641d8c5

…d_task.hpp

mkrainiuk approved these changes Nov 2, 2022

View reviewed changes

mkrainiuk merged commit b8ec0cf into uxlfoundation:develop Nov 2, 2022

		@@ -0,0 +1,46 @@
		#--===============================================================================
		# Copyright 2020-2022 Intel Corporation

Conversation

TejaX-Alaghari commented Aug 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

All Submissions

New features

Uh oh!

mmeterel commented Aug 10, 2022

Uh oh!

aelizaro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aelizaro Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

vmalia Oct 20, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aelizaro left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TejaX-Alaghari commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TejaX-Alaghari commented Oct 19, 2022

Uh oh!

vmalia Oct 20, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vmalia Oct 20, 2022

Choose a reason for hiding this comment

Uh oh!

TejaX-Alaghari Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vmalia Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

mkrainiuk Oct 31, 2022

Choose a reason for hiding this comment

Uh oh!

TejaX-Alaghari commented Nov 1, 2022

Uh oh!

TejaX-Alaghari commented Nov 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkrainiuk left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

TejaX-Alaghari commented Aug 1, 2022 •

edited

Loading

aelizaro left a comment •

edited

Loading

TejaX-Alaghari commented Oct 18, 2022 •

edited

Loading

TejaX-Alaghari Oct 27, 2022 •

edited

Loading

TejaX-Alaghari commented Nov 1, 2022 •

edited

Loading