[BLAS, hipSYCL] Add CUDA_CUDA_LIBRARY to also link against libcuda.so#249
Merged
andrewtbarker merged 1 commit intouxlfoundation:developfrom Nov 16, 2022
Merged
Conversation
1 task
mkrainiuk
approved these changes
Nov 11, 2022
Contributor
mkrainiuk
left a comment
mkrainiuk
left a comment
There was a problem hiding this comment.
Thank you for the fix! The changes look good to me.
andrewtbarker
approved these changes
Nov 11, 2022
Contributor
andrewtbarker
left a comment
andrewtbarker
left a comment
There was a problem hiding this comment.
Looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #228 added calls to
cuStreamSynchronizein the cuBLAS backend. This function is located inlibcuda.sobut this library is not linked against when using hipSYCL to compile oneMKL. This PR addsCUDA_CUDA_LIBRARYinFindcuBLAS.cmaketo fix this.Checklist
The tests do not pass currently on my setup, see [cuBLAS] cuBLAS test sometimes segfaults with dpc++ and hipSYCL #245, but it seems very unlikely that this is related to the change in this PR.
Does not apply here.