Skip to content

Comments

[FFT] mklcpu backned#265

Closed
anantsrivastava30 wants to merge 34 commits intouxlfoundation:developfrom
anantsrivastava30:FFT_MKLCPU_backned
Closed

[FFT] mklcpu backned#265
anantsrivastava30 wants to merge 34 commits intouxlfoundation:developfrom
anantsrivastava30:FFT_MKLCPU_backned

Conversation

@anantsrivastava30
Copy link
Contributor

@anantsrivastava30 anantsrivastava30 commented Jan 5, 2023

Description

enbling MKLCPU backend for oneMKL FFT interfaces
Please include a summary of the change. Please also include relevant
motivation and context. See
contribution guidelines
for more details. If the change fixes an issue not documented in the project's
Github issue tracker, please document all steps necessary to reproduce it.

Fixes # (GitHub issue)

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log.
  • Have you formatted the code using clang-format?

New interfaces

  • Have you provided motivation for adding a new feature as part of RFC and
    it was accepted? # (RFC)
  • What version of oneAPI spec the interface is targeted?
  • Complete New features checklist

New features

  • Have you provided motivation for adding a new feature?
  • Have you added relevant tests?

Bug fixes

  • Have you added relevant regression tests?
  • Have you included information on how to reproduce the issue (either in a
    GitHub issue or in this PR)?

hjabird and others added 16 commits December 29, 2022 15:30
Co-authored-by: Anant Srivastava <anant.srivastava@intel.com>
Co-authored-by: Tadej Ciglaric <tadej.c@gmail.com>

* Implements DFT common functionality
* Implements MKLGPU backend
* Tested against adapted examples from closed-source MKLGPU library and prototype
  unit tests (to be submitted in another PR).
* Implements DFT common functionality
* Implements MKLGPU backend
* Tested against adapted examples from closed-source MKLGPU library and prototype
  unit tests (to be submitted in another PR).

Co-authored-by: Anant Srivastava <anant.srivastava@intel.com>
Co-authored-by: Tadej Ciglaric <tadej.c@gmail.com>
* It may be desireable to link to only libonemkl_dft_mklgpu without
the need to also link to libonemkl_dft.
* To allow this, the OneMKL interface must be duplicated within the
backend library.
* This PR duplicates the interface, allowing direct linking.
@anantsrivastava30 anantsrivastava30 marked this pull request as draft January 30, 2023 20:01
@anantsrivastava30 anantsrivastava30 marked this pull request as ready for review February 2, 2023 05:35
@anantsrivastava30 anantsrivastava30 changed the title Fft mklcpu backned [FFT] mklcpu backned Feb 8, 2023
@anantsrivastava30
Copy link
Contributor Author

Tests log :
test.log

@anantsrivastava30
Copy link
Contributor Author

Closing, new sync'd PR at #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants