[MKL][CUBLAS] add the omatcopy and omatadd functions in row-major layout#333
Merged
andrewtbarker merged 5 commits intouxlfoundation:developfrom Nov 9, 2023
Merged
Conversation
Contributor
|
Contributor
Author
|
Attached is the test.log |
Contributor
Author
|
Can you please review the PR ? Thanks. |
andrewtbarker
approved these changes
Jul 25, 2023
Contributor
andrewtbarker
left a comment
andrewtbarker
left a comment
There was a problem hiding this comment.
I applied clang-format, and now this looks good to me. Thanks for the contribution!
Contributor
Author
|
It is a comment. I read the formatted codes. There are many function arguments for a MKL function. After formatting, closely related function arguments may be on multiple lines. I didn't try the clang format, but understands that the clang format is required. Thank you for your initial pull request. It provides a guide for me. |
jinz2014
changed the title
Contributor
Author
|
@mmeterel I slightly update the descriptions of the PR, and @andrewtbarker applied the Clang format. Thanks for your review. |
muhammad-tanvir-1211
approved these changes
Nov 9, 2023
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
…out (uxlfoundation#333) Co-authored-by: Jin Z <5zj@equinox.ftpn.ornl.gov> Co-authored-by: Andrew T. Barker <andrew1.barker@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a use case for omatcopy in the row-major order. More details are shown in https://github.com/zjin-lcf/HeCBench/tree/master/geam-sycl