[rocBLAS] Fix issues with rocBLAS 4.0.0

[nilsfriess]

Description

rocBLAS 4.0.0 removed support for the legacy BLAS inplace trmm, so calls to trmm cause a compilation error. The old functionality is provided by just duplicating the last two arguments of trmm (see also here).

To fix this, I am defining a macro ROCBLAS_NO_LEGACY_TRMM depending on the rocBLAS version which is then used in an #ifdef to decide which version of the function to call.

I also had to change slightly the way the path to librocblas.so is constructed in FindrocBLAS.cmake. I'm not sure if this is also related to the rocBLAS version or if this is a general issue on some systems, so I can also put that in a separated PR if you prefer.

Checklist

All Submissions

• Do all unit tests pass locally? Attach a log.
  I don't have an AMD gpu to test, I'm just assessing the state of compiling oneMKL with AdaptiveCpp to see if [hipSYCL] Add hipSYCL GitHub CI #307 needs any updates and can the maybe be merged.
• Have you formatted the code using clang-format?

[mmeterel]

@nilsfriess Thanks for the PR. I think this needs to be tested. You can contact me or infra team ( @toxicscum ) to access AMD GPUs.

[npmiller]

Suggested change

	#ifdef ROCBLAS_NO_LEGACY_TRMM
	#if ROCBLAS_VERSION_MAJOR >= 3

We can use ROCBLAS_VERSION_MAJOR, that way we don't need to add a new define, also since it's deprecated in rocBLAS 3 it gives warning so we could also use the new interface for rocBLAS 3.x.

I ran into the same issue and ended up with a similar patch before finding this PR. I didn't have any ROCBLAS_LIB_PATH issues with rocBLAS 4.x though.

[Rbiessy]

Thank you for the PR, we have recently removed the Findroc*.cmake files in #490 which should avoid the issues with ROCBLAS_LIB_PATH. Can you rebase your PR with the tip of develop?