Merged
Conversation
dnhsieh-intel
approved these changes
Jun 14, 2024
Contributor
dnhsieh-intel
left a comment
dnhsieh-intel
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you! I only have some minor comments.
rscohn2
force-pushed
the
dev/selective-again
branch
from
de08fe2 to
53a5f41
Compare
Rbiessy
approved these changes
Jul 2, 2024
Contributor
Rbiessy
left a comment
Rbiessy
left a comment
There was a problem hiding this comment.
I'm not familiar with javascript but this solution looks good to me and simple enough for anyone to adapt.
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring back selective testing: #509
Fixes issues:
node .github/scripts/domain-check.jsto run tests