[RNG] Added -fsycl -fsycl-device-code-split=per_kernel at the linking stage to have device code#533
Merged
egrabovskaya merged 7 commits intouxlfoundation:developfrom Jul 18, 2024
Conversation
Rbiessy
reviewed
Jul 11, 2024
… to have device code
egrabovskaya
force-pushed
the
dev/egrabovs/MKLD-17512_device_tests_example_failures_fix
branch
from
4a2da51 to
5890883
Compare
Rbiessy
approved these changes
Jul 15, 2024
andreyfe1
approved these changes
Jul 18, 2024
aelizaro
approved these changes
Jul 18, 2024
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
… stage to have device code because of failures on windows (uxlfoundation#533)
egrabovskaya
deleted the
dev/egrabovs/MKLD-17512_device_tests_example_failures_fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We must pass
-fsyclflag at the linking stage in addition to the compilation stage so that device code is added to executable file from object file on Windows.Otherwise, there is the failure in Device API tests and example: No kernel named ZTSZZN12moments_testIN6oneapi3mkl3rng6device13philox4x32x10ILi1EEENS3_7uniformIfNS3_14uniform_method8standardEEEEclIN4sycl3_V15queueEEEvT_ENKUlRNSD_7handlerEE_clESH_EUlNSD_4itemILi1ELb1EEEE was found -46 (PI_ERROR_INVALID_KERNEL_NAME)
Fixes # (GitHub issue)
Checklist
All Submissions
logs_win_static.txt
New interfaces
it was accepted? # (RFC)
New features
Bug fixes
GitHub issue or in this PR)?