[BLAS][DFT][SPARSE][TESTS] Remove .template from get_host_access to fix build#534
Merged
Rbiessy merged 3 commits intouxlfoundation:developfrom Jul 16, 2024
Merged
Conversation
This fixes the build. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
JackAKirk
changed the title
get_host_access to fix buildget_host_access to fix build
Contributor
|
Thanks for the fix! I see there are other occurrences of |
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Contributor
Author
Apologies, somehow my checkout didn't pull those folders. I've fixed them too now. |
JackAKirk
changed the title
get_host_access to fix buildget_host_access to fix build
Rbiessy
approved these changes
Jul 12, 2024
andrewtbarker
approved these changes
Jul 12, 2024
Contributor
andrewtbarker
left a comment
andrewtbarker
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Contributor
|
Merging now as suggested in my email. |
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
… fix build (uxlfoundation#534) Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove .template from
get_host_accessto fix build. This is also cleaner code.This fixes the build that became broken apparently due to a clang change: llvm/llvm-project#94049
Note that a dpc++ patch is also required to fix the build due to an unrelated issue to the one described above:
intel/llvm#14529