Skip to content

[RNG] Workaround for get_multi_ptr with AdaptiveCPP#535

Merged
iMartyan merged 5 commits intouxlfoundation:developfrom
iMartyan:dev/imartyan/acpp_get_ptr
Jul 12, 2024
Merged

[RNG] Workaround for get_multi_ptr with AdaptiveCPP#535
iMartyan merged 5 commits intouxlfoundation:developfrom
iMartyan:dev/imartyan/acpp_get_ptr

Conversation

@iMartyan
Copy link
Contributor

Description

This fix adds a workaround for AdaptiveCPP compiler as they not yet support the get_multi_ptr function.

Checklist

All Submissions

  • Do all unit tests pass locally? Attach a log.
  • Have you formatted the code using clang-format?

@iMartyan
Copy link
Contributor Author

acpp_log.txt

Test log

Copy link
Contributor

@andreyfe1 andreyfe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@egrabovskaya egrabovskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well

@Rbiessy
Copy link
Contributor

Rbiessy commented Jul 12, 2024

Did you notice that AdaptiveCpp merged this PR recently? AdaptiveCpp/AdaptiveCpp#1452
I think this should add support for get_multi_ptr so this fix may not be needed anymore.

@iMartyan
Copy link
Contributor Author

Did you notice that AdaptiveCpp merged this PR recently? AdaptiveCpp/AdaptiveCpp#1452 I think this should add support for get_multi_ptr so this fix may not be needed anymore.

Thank you for pointing that!
I see that they have not updated the version yet: Releases.
I suggest to leave the workaround for now and drop it when SYCL2020 will be officially supported in AdaptiveCPP.

@Rbiessy
Copy link
Contributor

Rbiessy commented Jul 12, 2024

"Officially supporting SYCL 2020" may be more complicated than it sounds but it's fair to keep this workaround until a release of AdaptiveCpp is able to compile oneMKL Interface. Thanks

@iMartyan iMartyan merged commit 8abfdfc into uxlfoundation:develop Jul 12, 2024
normallytangent pushed a commit to normallytangent/oneMKL that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants