[CI]: support pagination when fetching the files changed in the PR#540
Merged
rscohn2 merged 1 commit intouxlfoundation:developfrom Jul 30, 2024
Merged
[CI]: support pagination when fetching the files changed in the PR#540rscohn2 merged 1 commit intouxlfoundation:developfrom
rscohn2 merged 1 commit intouxlfoundation:developfrom
Conversation
dnhsieh-intel
approved these changes
Jul 16, 2024
Contributor
dnhsieh-intel
left a comment
dnhsieh-intel
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Member
Author
|
@mkrainiuk: I need another reviewer. I tested the change in a fork. |
mkrainiuk
approved these changes
Jul 29, 2024
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The logic to only test domains that changed was failing to test some domains because the API for returning the list of changed files uses pagination, and the code was only examining the first page. Added proper support for pagination.
See a test PR with many files in a fork: rscohn2#13
Fixes #539