[rocblas] Use enqueue_native_command ext if available#581
Merged
Rbiessy merged 1 commit intouxlfoundation:developfrom Oct 8, 2024
Merged
Conversation
This makes use of the enqueue_native_command dpc++ extension if it is available. This improves performance and integrates correctly with the dpc++ scheduler. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Contributor
Author
|
@oneapi-src/onemkl-blas-write could you please review this? Thanks |
andrewtbarker
approved these changes
Oct 4, 2024
Contributor
andrewtbarker
left a comment
andrewtbarker
left a comment
There was a problem hiding this comment.
Looks good, thanks!
Rbiessy
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes use of the enqueue_native_command dpc++ extension if it is available. This improves performance and integrates correctly with the dpc++ scheduler.
This matches very closely to the cublas impl from #572
Please see the description of #572 for further details.
tests:
test_main_blas_ct.txt
test_main_blas_rt.txt