Skip to content

Fix typo #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Open an Request For Comment (RFC) issue when contributing new interfaces. In the

* The definition of the function including the interface and semantics, and how this interface will be extendable for different HW implementations.

* What exisitng libraries have implementation of this function and can be used under the oneMKL interface.
* What existing libraries have implementation of this function and can be used under the oneMKL interface.


## Bug Reporting
Expand Down Expand Up @@ -322,4 +322,4 @@ for (int i = 0; i < loop_size; i++) ...;

oneMKL uses GoogleTest for functional testing.

Be sure to extend the existing tests when fixing an issue, adding a new interface or new implementation under exisitng interfaces.
Be sure to extend the existing tests when fixing an issue, adding a new interface or new implementation under existing interfaces.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ There are two oneMKL selector layer implementations:
Example of app.cpp with run-time dispatching:

```cpp
include "oneapi/mkl.hpp"
#include "oneapi/mkl.hpp"

...
cpu_dev = cl::sycl::device(cl::sycl::cpu_selector());
Expand All @@ -80,7 +80,7 @@ $> clang++ -fsycl app.o –L$ONEMKL/lib –lonemkl
Example of app.cpp with compile-time dispatching:

```cpp
include "oneapi/mkl.hpp"
#include "oneapi/mkl.hpp"

...
cpu_dev = cl::sycl::device(cl::sycl::cpu_selector());
Expand Down Expand Up @@ -482,7 +482,7 @@ Then:
# Inside <path to onemkl>
mkdir build && cd build
export CXX=<path_to_dpcpp_compiler>/bin/dpcpp;
cmake .. [-DMKL_ROOT=<mkl_install_prefix>] \ # required only if enviroment variable MKLROOT is not set
cmake .. [-DMKL_ROOT=<mkl_install_prefix>] \ # required only if environment variable MKLROOT is not set
[-DREF_BLAS_ROOT=<reference_blas_install_prefix>] # required only for testing
cmake --build .
ctest
Expand All @@ -493,7 +493,7 @@ cmake --install . --prefix <path_to_install_dir>
# Inside <path to onemkl>
md build && cd build
cmake .. -G Ninja -DCMAKE_TOOLCHAIN_FILE="..\cmake\toolchain\intel_clang-cl-toolchain.cmake"
[-DMKL_ROOT=<mkl_install_prefix>] \ # required only if enviroment variable MKLROOT is not set
[-DMKL_ROOT=<mkl_install_prefix>] \ # required only if environment variable MKLROOT is not set
[-DREF_BLAS_ROOT=<reference_blas_install_prefix>] # required only for testing

ninja
Expand Down
2 changes: 1 addition & 1 deletion deps/googletest/include/gtest/gtest-printers.h
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,7 @@ void UniversalTersePrint(const T& value, ::std::ostream* os) {
// NUL-terminated string.
template <typename T>
void UniversalPrint(const T& value, ::std::ostream* os) {
// A workarond for the bug in VC++ 7.1 that prevents us from instantiating
// A workaround for the bug in VC++ 7.1 that prevents us from instantiating
// UniversalPrinter with T directly.
typedef T T1;
UniversalPrinter<T1>::Print(value, os);
Expand Down
2 changes: 1 addition & 1 deletion deps/googletest/include/gtest/internal/gtest-filepath.h
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ class GTEST_API_ FilePath {

void Normalize();

// Returns a pointer to the last occurence of a valid path separator in
// Returns a pointer to the last occurrence of a valid path separator in
// the FilePath. On Windows, for example, both '/' and '\' are valid path
// separators. Returns NULL if no path separator was found.
const char* FindLastPathSeparator() const;
Expand Down
2 changes: 1 addition & 1 deletion deps/googletest/include/gtest/internal/gtest-port.h
Original file line number Diff line number Diff line change
Expand Up @@ -1069,7 +1069,7 @@ struct ConstRef<T&> { typedef T& type; };
// const Foo*). When you use ImplicitCast_, the compiler checks that
// the cast is safe. Such explicit ImplicitCast_s are necessary in
// surprisingly many situations where C++ demands an exact type match
// instead of an argument type convertable to a target type.
// instead of an argument type convertible to a target type.
//
// The syntax for using ImplicitCast_ is the same as for static_cast:
//
Expand Down
8 changes: 4 additions & 4 deletions deps/googletest/src/gtest-internal-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -513,9 +513,9 @@ class GTEST_API_ UnitTestImpl {
virtual ~UnitTestImpl();

// There are two different ways to register your own TestPartResultReporter.
// You can register your own repoter to listen either only for test results
// You can register your own reporter to listen either only for test results
// from the current thread or for results from all threads.
// By default, each per-thread test result repoter just passes a new
// By default, each per-thread test result reporter just passes a new
// TestPartResult to the global test result reporter, which registers the
// test part result for the currently running test.

Expand Down Expand Up @@ -1153,13 +1153,13 @@ class StreamingListener : public EmptyTestEventListener {
}

// Note that "event=TestCaseStart" is a wire format and has to remain
// "case" for compatibilty
// "case" for compatibility
void OnTestCaseStart(const TestCase& test_case) override {
SendLn(std::string("event=TestCaseStart&name=") + test_case.name());
}

// Note that "event=TestCaseEnd" is a wire format and has to remain
// "case" for compatibilty
// "case" for compatibility
void OnTestCaseEnd(const TestCase& test_case) override {
SendLn("event=TestCaseEnd&passed=" + FormatBool(test_case.Passed()) +
"&elapsed_time=" + StreamableToString(test_case.elapsed_time()) +
Expand Down
2 changes: 1 addition & 1 deletion deps/googletest/src/gtest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ const char kStackTraceMarker[] = "\nStack trace:\n";
// specified on the command line.
bool g_help_flag = false;

// Utilty function to Open File for Writing
// Utility function to Open File for Writing
static FILE* OpenFileForWriting(const std::string& output_file) {
FILE* fileout = nullptr;
FilePath output_file_path(output_file);
Expand Down
2 changes: 1 addition & 1 deletion include/oneapi/mkl/rng/distributions.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ class lognormal {
// oneapi::mkl::rng::bernoulli_method::icdf;
//
// Input arguments:
// p - success probablity of a trial. 0.5 by default
// p - success probability of a trial. 0.5 by default

namespace bernoulli_method {
struct icdf {};
Expand Down
2 changes: 1 addition & 1 deletion src/blas/backends/cublas/cublas_helper.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace blas {
namespace cublas {

// The static assert to make sure that all index types used in
// src/oneMKL/backend/cublas/blas.hpp inteface are int64_t
// src/oneMKL/backend/cublas/blas.hpp interface are int64_t
template <typename... Next>
struct is_int64 : std::false_type {};

Expand Down
2 changes: 1 addition & 1 deletion src/blas/backends/cublas/cublas_scope_handle.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class CublasScopedContextHandler {

~CublasScopedContextHandler() noexcept(false);
/**
* @brief get_handle: creates the handle by implicitely impose the advice
* @brief get_handle: creates the handle by implicitly impose the advice
* given by nvidia for creating a cublas_handle. (e.g. one cuStream per device
* per thread).
* @param queue sycl queue.
Expand Down
2 changes: 1 addition & 1 deletion tests/unit_tests/include/test_helper.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class LayoutDeviceNamePrint {
}
};

/* to accomodate Windows and Linux differences between alligned_alloc and
/* to accommodate Windows and Linux differences between alligned_alloc and
_aligned_malloc calls use oneapi::mkl::aligned_alloc and oneapi::mkl::aligned_free instead */
namespace oneapi {
namespace mkl {
Expand Down