Return value of bounded concurrent queue pop()

[FloopCZ]

Hi everyone,

the OneAPI spec claims that concurrent bounded queue pop() function returns void:

void pop( value_type& result );

However, the implementation returns a bool:
https://github.com/oneapi-src/oneTBB/blob/05023723ff17dc436668a989a5f2c1873e994e72/include/oneapi/tbb/concurrent_queue.h#L380

What is the purpose of this boolean return value? Thank you.

[alexey-katranov]

It always returns true. It seems like misalignment with specification. However, changing the return value to void might break the existing code.

[FloopCZ]

ok, thank you for the info
Maybe it could be changed in the next major version or mentioned in the docs, what do you think?

[alexey-katranov]

Yes, it makes sense to mention somewhere, e.g. in release notes. I will follow up with the team.

The next major version is also an option but there is no any plans about the next major version.

[alexey-katranov]

During team discussion, we agreed that it is a bug that can be fixed without waiting for the major version.