Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent-queue pop comment #809

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

kopalja
Copy link
Contributor

@kopalja kopalja commented Mar 18, 2022

Description

Move does-not-wait comment to operation which actually does not wait (try_pop).

@kopalja kopalja changed the title fix concurrent-queue pop comment Fix concurrent-queue pop comment Mar 18, 2022
@anton-potapov
Copy link
Contributor

@kopalja, for CI to pass, year in the copyright header of the touched file should be updated

@omalyshe
Copy link
Contributor

@kopalja Please, fix the copyright year as suggested in https://github.com/oneapi-src/oneTBB/runs/5601695962?check_suite_focus=true

Copy link
Contributor

@anton-potapov anton-potapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anton-potapov
Copy link
Contributor

anton-potapov commented Mar 30, 2022

@kopalja , please add Sign-off-by line to git commit message , according to https://github.com/oneapi-src/oneTBB/blob/master/CONTRIBUTING.md

@kboyarinov kboyarinov merged commit 01fa141 into uxlfoundation:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants