Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CPU binding on HCC Windows systems #1575

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Conversation

isaevil
Copy link
Contributor

@isaevil isaevil commented Dec 4, 2024

Description

Current implementation of thread pinning with HWLOC usage on Windows is not scalable and already does not work on HCC systems like SPR with multiple NUMA nodes. It doesn't work because hwloc_set_cpubind uses SetThreadGroupAffinity on Windows and this API doesn't allow setting affinity across multiple processor groups.

This patch fixes binding by shrinking the mask to fit a particular processor group based on slot number in arena.

Fixes # - issue number(s) if exists

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Signed-off-by: Isaev, Ilya <ilya.isaev@intel.com>
Signed-off-by: Isaev, Ilya <ilya.isaev@intel.com>
Copy link
Contributor

@aleksei-fedotov aleksei-fedotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isaevil isaevil merged commit 7a60b70 into master Dec 10, 2024
25 checks passed
@isaevil isaevil deleted the dev/isaevil/windows-hcc-cpubind branch December 10, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants