Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid -Wstringop-overflow in GCC 14 #1583

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ashvardanian
Copy link
Contributor

@ashvardanian ashvardanian commented Dec 9, 2024

Description

Relates to the bug #843 - reappearing with GCC 14.

Type of change

  • bug fix
  • new feature
  • tests
  • infrastructure
  • documentation

Tests

  • added
  • not needed

Documentation

  • updated
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

@kboyarinov, @dnmokhov

Other information

@phprus
Copy link
Contributor

phprus commented Dec 9, 2024

Please update this condition also in cmake config for gcc:

# Suppress GCC 12.x-13.x warning here that to_wait_node(n)->my_is_in_list might have size 0
set(TBB_COMMON_LINK_FLAGS ${TBB_COMMON_LINK_FLAGS} $<$<AND:$<NOT:$<VERSION_LESS:${CMAKE_CXX_COMPILER_VERSION},12.0>>,$<VERSION_LESS:${CMAKE_CXX_COMPILER_VERSION},14.0>>:-Wno-stringop-overflow>)

@ashvardanian
Copy link
Contributor Author

Thanks for a fast response, @phprus! I've updated the condition. Let me know if something else is needed 🤗

@dnmokhov
Copy link
Contributor

Thanks for the patch, @ashvardanian! Could you please also update the copyright year in the header file?

@ashvardanian
Copy link
Contributor Author

@dnmokhov, done ;)

Copy link
Contributor

@kboyarinov kboyarinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kboyarinov kboyarinov merged commit 4719ac1 into uxlfoundation:master Dec 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants