Allow to disable tbbmalloc (oneTBB) #326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
By setting TBB_USE_MALLOC environment variable to 1 the user can disable scalable allocator from tbbmalloc and use system allocator through malloc/posix_memalign/free API. There are other, more performant memory allocators, like tcmalloc for example, which the user might want to use instead of tbbmalloc. Also, using the system allocator can be useful with memory debugging and profiling tools, like valgrind. Such tools usually provide their own implementations of memory allocation functions, and we want those functions to be used by TBB. Signed-off-by: Andrey Semashev <andrey.semashev@gmail.com>
Lastique
force-pushed
the
disable_tbbmalloc_onetbb_2021
branch
from
e9ed85c to
ca7648e
Compare
Lastique
changed the title
|
The patch to enable support for |
Comment on lines
+120
to
+121
| if (!GetBoolEnvironmentVariable("TBB_USE_MALLOC")) | ||
| success = dynamic_link(MALLOCLIB_NAME, MallocLinkTable, 4); |
There was a problem hiding this comment.
Have you considered an approach to extend global_control functionality? Usually, we try to avoid configuration via environment variables.
There was a problem hiding this comment.
Yes, the rationale and discussion about global_control is in the previous version of this PR: #149. The short version is that we want to ensure that tbbmalloc is not enabled if TBB is used somewhere during global initialization of the program, and we want to propagate that setting to child processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #149 which targets the reworked code base of oneTBB 2021.1.1.
The patch adds
TBB_USE_MALLOCenvironment variable to force using system allocator.By setting
TBB_USE_MALLOCenvironment variable to 1 the user can disable scalable allocator from tbbmalloc and use system allocator throughmalloc/posix_memalign/freeAPI. There are other, more performant memory allocators, like tcmalloc for example, which the user might want to use instead of tbbmalloc. Also, using the system allocator can be useful with memory debugging and profiling tools, like valgrind. Such tools usually provide their own implementations of memory allocation functions, and we want those functions to be used by TBB.The original PR #149 contains some benchmarks and rationale as to why we prefer an environment variable as a way to disable tbbmalloc.