Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: convert TBB_SIGNTOOL path TO_CMAKE_PATH #701

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

AlexVeprev
Copy link
Contributor

Signed-off-by: Veprev, Alexey alexey.veprev@intel.com

Description

Add comprehensive description of proposed changes

This small fix is required to avoid possible warning Invalid escape sequence if TBB_SIGNTOOL is specified in Windows-style (with \) and some escape sequences accidentally appear in that path

Fixes # - issue number(s) if exists -

  • - git commit message contains appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add respective label(s) to PR if you have permissions

  • bug fix - change which fixes an issue
  • new feature - change which adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and for some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications @zheltovs

Other information

Signed-off-by: Veprev, Alexey alexey.veprev@intel.com
@AlexVeprev AlexVeprev requested a review from zheltovs December 24, 2021 19:39
@AlexVeprev AlexVeprev self-assigned this Dec 24, 2021
@AlexVeprev AlexVeprev requested a review from leeks-int December 24, 2021 20:22
@AlexVeprev AlexVeprev merged commit 0860b7f into master Dec 27, 2021
@AlexVeprev AlexVeprev deleted the dev/AlexVeprev/cmake-fix-signtool branch December 27, 2021 08:15
kboyarinov pushed a commit that referenced this pull request Dec 27, 2021
Signed-off-by: Veprev, Alexey alexey.veprev@intel.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants