changed TBB_EXPORT to use gcc visibility attribute #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #define _EXPORT | ||
| #elif defined(__unix__) || defined(__APPLE__) // Use .def files for these | ||
| #define _EXPORT __attribute__ ((visibility ("default"))) |
There was a problem hiding this comment.
Rename _EXPORT to something __TBB_* to avoid possible conflicts with user code
| #else | ||
| #error "Unknown platform/compiler" | ||
| #endif | ||
|
|
||
| #if __TBB_BUILD | ||
| //#if __TBB_BUILD | ||
| #define TBB_EXPORT _EXPORT |
There was a problem hiding this comment.
Maybe __TBB_EXPORT because it is not public macro
Signed-off-by: Anton Potapov <anton.potapov@intel.com>
anton-potapov
force-pushed
the
fix_gcc_visibility_hidden
branch
2 times, most recently
from
b7d9a64 to
7302795
Compare
- temporary added -fvisibility=hidden to cmake for sake of testing Signed-off-by: Anton Potapov <anton.potapov@intel.com>
export malloc proxy functions
anton-potapov
force-pushed
the
fix_gcc_visibility_hidden
branch
from
2026e51 to
818b8e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
according to GCC symbols visibility wiki page as such (with
__attribute__((visibility ("default"))) exported symbols should be explicitly marked, to allow compilating with-fvisibility=hiddenflag.Fixes #779
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
@alexey-katranov
Other information