Fix: ld: warning: cannot export hidden symbol typeinfo for tbb::detail::r1::unsafe_wait…

[phprus]

… from CMakeFiles/tbb.dir/exception.cpp.o

Signed-off-by: Vladislav Shchapov phprus@gmail.com

Description

macOS 12.1
Xcode 13.2.1

Linker warning:

ld: warning: cannot export hidden symbol typeinfo for tbb::detail::r1::unsafe_wait from CMakeFiles/tbb.dir/exception.cpp.o

Fixes #713

• - git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

• bug fix - change that fixes an issue
• new feature - change that adds functionality
• tests - change in tests
• infrastructure - change in infrastructure and CI
• documentation - documentation update

Tests

• added - required for new features and some bug fixes
• not needed

Documentation

• updated in # - add PR number
• needs to be updated
• not needed

Breaks backward compatibility

• Yes
• No
• Unknown

Notify the following users

List users with @ to send notifications

Other information

[phprus]

cc @anton-potapov

[anton-potapov]

@phprus, thanks for the contribution! One thing bothers me a lot here - It seems we miss an understanding of what really is going on here, i,e, what forcing the compiler to issue the warning? is it known compiler bug/feature? Or our code breaking (probably unwritten) rules here?

[phprus]

@anton-potapov
unsafe_wait does not export any symbols from libtbb.dylib.
I think because of this the compiler/linker from xcode makes typeinfo hidden.

[phprus]

Xcode 14, same warning:

ld: warning: cannot export hidden symbol typeinfo for tbb::detail::r1::unsafe_wait from CMakeFiles/tbb.dir/exception.cpp.o

[phprus]

@pavelkumbrasev, @isaevil what do you think about this PR?

[phprus]

@pavelkumbrasev, @isaevil, @kboyarinov
ping?

[pavelkumbrasev]

@phprus So is it only a warning?

[phprus]

@pavelkumbrasev
This is a warning.
All oneTBB tests pass successfully. But, I don't know if it affects anything else.

[phprus]

Xcode 14.3 Beta 2 has same warning.

[phprus]

More correct solution: #1114

[isaevil]

@phprus close?

[phprus]

@isaevil
I guess that this warning cannot be fixed without changing the broken tbb::detail::r1::unsafe_wait ABI.
But, I need a little more time to research.

I will close PR now and reopen it or create a new PR if necessary.