-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid WORKING_DIRECTORY for tests #870
Conversation
ping? |
Rebased onto current master. |
Rebased |
Hi @phprus, how to reproduce this problem? |
I apologize for the delay and incorrect commands in the deleted comment. See CI results for commit phprus@dddd550
Or local:
Error:
|
Ping? |
@pavelkumbrasev, @isaevil what do you think about this PR? |
@phprus I don't quite like the idea that we are actually bypassing the value of |
@isaevil I will update the PR a bit later... |
We can also use |
@isaevil Test: https://github.com/phprus/oneTBB/tree/msvc_vs_wd-fix |
…tor (like Microsoft Visual Studio). Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@pavelkumbrasev, @isaevil ping? Rebased and changed copyright year in files. |
Description
Fix invalid
WORKING_DIRECTORY
for tests and multi-config CMake Generator (like Microsoft Visual Studio).In a multi-configuration environment, the
${CMAKE_RUNTIME_OUTPUT_DIRECTORY}
variable may not correspond to the actual directory where the executables will be.Error:
See:
https://github.com/oneapi-src/oneTBB/blob/323260671b40db33c9fc0d66d1f1eed6ecc82ce2/CMakeLists.txt#L156-L172
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@
to send notificationsOther information