Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: deselect failing NuSVC tests #1929

Merged

Conversation

ethanglaser
Copy link
Contributor

@ethanglaser ethanglaser commented Jul 9, 2024

Description

TBD on root cause but could be linked to public CI seg faults, or existing deselection.

There is no clear source of this issue. I have already checked sklearnex revisions just before potential causes (#1912, #1908 did not cause it)

Fixes # - issue number(s) if exists

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes, if necessary (updated in # - add PR number)
  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.
  • I have resolved any merge conflicts that might occur with the base branch.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)
  • I have added a respective label(s) to PR if I have a permission for that.

@ethanglaser
Copy link
Contributor Author

/intelci: run

@ethanglaser ethanglaser requested review from DDJHB and Vika-F July 9, 2024 22:35
@ethanglaser
Copy link
Contributor Author

/intelci: run

Copy link
Contributor

@icfaust icfaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure there is a ticket to analyze and fix this. that way it doesn't get lost

@ethanglaser
Copy link
Contributor Author

Ticket created, internal CI green, merging

@ethanglaser ethanglaser merged commit a2f4f5d into uxlfoundation:main Jul 10, 2024
15 of 18 checks passed
Alexsandruss added a commit to Alexsandruss/scikit-learn-intelex that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants