MAINT: utility module for Intel data parallel libs; import checks in one place #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
samir-nasibli
commented
Sep 11, 2024
|
/intelci: run |
samir-nasibli
commented
Sep 16, 2024
icfaust
reviewed
Sep 16, 2024
| def is_dpctl_available(targets=None): | ||
| try: | ||
| def is_dpctl_device_available(targets): | ||
| if dpctl_available: |
There was a problem hiding this comment.
if dpctl_available check can be made an import-time check, rather than runtime.
There was a problem hiding this comment.
moving out this boolean check doesn't give a lot, but moving out package import make sense. Going to move them out from primitives.
rename the module for dp utilities update dpnp/dpctl checkers reusing daal4py sklearn_check_version
|
/intelci: run |
samir-nasibli
changed the title
|
/intelci: run |
samir-nasibli
commented
Sep 23, 2024
|
/intelci: run |
|
/intelci: run |
Alexsandruss
approved these changes
Oct 21, 2024
samir-nasibli
commented
Oct 21, 2024
icfaust
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Great PR, I think its go to go, and is well written. Stylistically, I would swap "_dpep_helpers" for something like "_usm_array_api", "_usm_helpers", "_usm_utils", or something just for consistency/ if we add additional usm features later on that we want to centralize.
samir-nasibli
added a commit
to samir-nasibli/scikit-learn-intelex
that referenced
this pull request
Oct 26, 2024
13 tasks
samir-nasibli
added a commit
to samir-nasibli/scikit-learn-intelex
that referenced
this pull request
Oct 26, 2024
following uxlfoundation#1936
ethanglaser
added a commit
to ethanglaser/scikit-learn-intelex
that referenced
this pull request
Oct 29, 2024
13 tasks
ethanglaser
added a commit
that referenced
this pull request
Oct 29, 2024
david-cortes-intel
pushed a commit
to david-cortes-intel/scikit-learn-intelex
that referenced
this pull request
Oct 31, 2024
samir-nasibli
added a commit
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes centralized data parallel libs checks, such as DPCtl and DPNP availability. (Also discussed on #1861 (comment))
Proposed changes:
is_dpctl_available/is_dpnp_availbletools for checking the specific dpctl, dpnp versionsis_dpctl_availablefromonedal.tests.utils._device_selectionmodule tois_dpctl_device_available. This tool is used insklearnex/onedaltests where it is needed to check required device(s) availability viadpctl.Non prior. Should be integrated after main is unfreeze.