-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enh] Conda recipe update and CI OS version pinning #1992
[enh] Conda recipe update and CI OS version pinning #1992
Conversation
/intelci: run |
631bcc8
to
fc31cf2
Compare
/intelci: run |
1 similar comment
/intelci: run |
cde348f
to
cc66393
Compare
/intelci: run |
5a920a3
to
48a74af
Compare
/iintelci: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall pretty useful addition. I would beef up the description, separate out some of the other changes, and possibly drop sklearn 1.1 or 1.2 from the standard test matrix. The reason being is that by adding these two recipes, we are starting to really push our luck on azure pipeline runners. I'll let others weigh in on this @samir-nasibli @ethanglaser .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to be some sort of windows python conda issue. Your previous responses were sufficient for me. I found one issue with a re-enablement that may require running private CI, maybe some clarity could explain it away as an alternate solution. If we solve these small issues, I think it would be ready.
/intelci: run |
@Alexsandruss please rebase your branch. |
66b7fab
to
3386770
Compare
/intelci: run |
1 similar comment
/intelci: run |
/intelci: run |
1 similar comment
/intelci: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some last questions from me. Thanks for the updates based off the previous comments.
Question: are the commands in |
INSTALL.md
Outdated
|
||
* any `conda` distribution (`miniforge` is recommended) | ||
* `conda-build` and `conda-verify` installed in a conda environment | ||
* (Windows only) Microsoft Visual Studio* 2022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we point to general VS/compiler requirements so we would have single place to track/update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really in case of conda recipe, vs2022 is default for this repo and included in CI Windows image, vs2019 - for conda-forge feedstock, and build config change is required to set another version and there is no guarantee it will work as expected (but it is unlikely someone will use version other than 2019 or 2022).
I will add mention how to change compiler for conda-build on Win.
/intelci: run |
@Alexsandruss This was merged with an error in the WindowsCondaEnv Python3.12_Sklearn1.5 step |
The error appears to be sporadic though. |
Description
Scikit-learn-intelex conda recipe update.
Changes:
Conda-forge checks: conda-forge/scikit-learn-intelex-feedstock#38
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance