Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: deprecate fallback to sklearn after onedal in LogReg #1996

Closed
wants to merge 2 commits into from
Closed

DEP: deprecate fallback to sklearn after onedal in LogReg #1996

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaa2f40
DEP: deprecate fallback to sklearn after onedal in LogReg
samir-nasibli Aug 9, 2024
a7a2241
Merge branch 'intel:main' into dep/skl_fallback_after_onedal_logreg
samir-nasibli Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions sklearnex/linear_model/logistic_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,17 +304,8 @@ def _onedal_fit(self, X, y, sample_weight=None, queue=None):
)

self._initialize_onedal_estimator()
try:
self._onedal_estimator.fit(X, y, queue=queue)
self._save_attributes()
except RuntimeError:
logging.getLogger("sklearnex").info(
f"{self.__class__.__name__}.fit "
+ get_patch_message("sklearn_after_onedal")
)

del self._onedal_estimator
super().fit(X, y)
self._onedal_estimator.fit(X, y, queue=queue)
self._save_attributes()

def _onedal_predict(self, X, queue=None):
if queue is None or queue.sycl_device.is_cpu:
Expand Down