-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable PR checklist workflow and update PR template #2071
Merged
Alexsandruss
merged 12 commits into
uxlfoundation:main
from
Alexsandruss:dev/pr-template-extension
Sep 30, 2024
Merged
Enable PR checklist workflow and update PR template #2071
Alexsandruss
merged 12 commits into
uxlfoundation:main
from
Alexsandruss:dev/pr-template-extension
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexsandruss
requested review from
maria-Petrova,
napetrov,
bdmoore1,
homksei,
ahuber21 and
ethanglaser
as code owners
September 26, 2024 14:19
Alexsandruss
force-pushed
the
dev/pr-template-extension
branch
from
September 26, 2024 15:56
6c2582c
to
111550d
Compare
samir-nasibli
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Alexsandruss ! There are no big comments from my side. If anything, we can always update with as a follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
New template
Description
Add a comprehensive description of proposed changes
List associated issue number(s) if exist(s): #6 (for example)
Documentation PR (if needed): #1340 (for example)
Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance