-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: adding array-api-compat
and enabling array api conformance tests
#2079
Merged
samir-nasibli
merged 10 commits into
uxlfoundation:main
from
samir-nasibli:enh/array_api_dispatching
Oct 9, 2024
Merged
ENH: adding array-api-compat
and enabling array api conformance tests
#2079
samir-nasibli
merged 10 commits into
uxlfoundation:main
from
samir-nasibli:enh/array_api_dispatching
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added array-api-compat to test env
samir-nasibli
changed the title
ENH: array api dispatching
ENH: adding Oct 3, 2024
array-api-compat
and enabling array api conformance tests
samir-nasibli
commented
Oct 8, 2024
- decomposition/tests/test_pca.py::test_pca_array_api_compliance[PCA(n_components=2,svd_solver='covariance_eigh',whiten=True)-check_array_api_get_precision-array_api_strict-None-None] | ||
- linear_model/tests/test_ridge.py::test_ridge_array_api_compliance[Ridge(solver='svd')-check_array_api_attributes-array_api_strict-None-None] | ||
- linear_model/tests/test_ridge.py::test_ridge_array_api_compliance[Ridge(solver='svd')-check_array_api_input_and_values-array_api_strict-None-None] | ||
# `train_test_split` inconsistency for Array API inputs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be covered by ticket.
samir-nasibli
requested review from
napetrov,
Alexsandruss,
homksei,
ahuber21 and
ethanglaser
as code owners
October 8, 2024 20:09
samir-nasibli
requested review from
icfaust
and removed request for
ahuber21,
napetrov and
homksei
October 8, 2024 20:09
samir-nasibli
force-pushed
the
enh/array_api_dispatching
branch
from
October 8, 2024 22:40
ced43bf
to
404e8c0
Compare
13 tasks
icfaust
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assume a follow-up ticket will be generated for private CI checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
array-api-compat
and enabling array api conformance tests.Done:
train_test_split
inconsistency for Array API inputs.Documentation PR (if needed): #1340 (for example)
Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance