Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] interface with compressed artifacts oneapi-src/oneDAL#2938 #2093

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Oct 8, 2024

Description

Updates interfaces and uses symlinks to reduce the maintenance burden with compiler/tbb updates. This matches the changes in uxlfoundation/oneDAL#2938 and should be merged just after. This will make managing the windows basekit simpler (only done on oneDAL-side).

This is a CI only change and doesn't require performance benchmarking.


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@icfaust icfaust marked this pull request as ready for review October 10, 2024 08:33
@icfaust icfaust added enhancement New feature or request infra labels Oct 10, 2024
@icfaust
Copy link
Contributor Author

icfaust commented Oct 10, 2024

https://github.com/icfaust/scikit-learn-intelex/actions/runs/11264131226 Example of a successful run from my fork. I will rerun after uxlfoundation/oneDAL#2938 is merged (to show green)

@icfaust
Copy link
Contributor Author

icfaust commented Oct 17, 2024

@icfaust icfaust merged commit 48cf043 into uxlfoundation:main Oct 17, 2024
24 checks passed
@samir-nasibli
Copy link
Contributor

@icfaust please mark the PR ready for the review only after green CI.
After green CI in less than one day PR was merged.

Post factum, I can point out that the changes looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants