Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] make design_rule trace data more user-friendly in test_common.py #2111

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Oct 15, 2024

Description

Switch from list to dict to simplify user interaction and make it easier to understand.

Only modifies tests, no performance measurements necessary.


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

Copy link
Contributor

@ahuber21 ahuber21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Can you confirm caching still works as expected?

@icfaust
Copy link
Contributor Author

icfaust commented Oct 15, 2024

Much better. Can you confirm caching still works as expected?

Good question, should show as failures in CI if it can't properly access the cached data.

@icfaust
Copy link
Contributor Author

icfaust commented Oct 15, 2024

/intelci: run

@icfaust icfaust marked this pull request as ready for review October 15, 2024 10:31
@icfaust icfaust added the infra label Oct 15, 2024
@icfaust icfaust merged commit 2dd89cd into uxlfoundation:main Oct 15, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants