Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] Remove linux hardcoding from daal4py's _launch_algorithms.py #2121

Merged
merged 9 commits into from
Oct 23, 2024

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Oct 21, 2024

Description

At some point this testing should be removed as it is testing deprecated daal4py code, and all non-deprecated code is being tested more extensively in sklearnex. This change provides assurance that windows path finding is properly accomplished. No performance benchmarking necessary. I will run the CI several times in order to try and get a sporadic failure.


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@icfaust icfaust changed the title [testing, CI] fix WindowsCondaRecipe Python3.12_Sklearn1.5 failure - Work in Progress [testing, CI] fix WindowsCondaRecipe Python3.12 failure - Work in Progress Oct 21, 2024
@icfaust icfaust changed the title [testing, CI] fix WindowsCondaRecipe Python3.12 failure - Work in Progress [testing, CI] Remove linux hardcoding from daal4py's _launch_algorithms Oct 21, 2024
@icfaust icfaust changed the title [testing, CI] Remove linux hardcoding from daal4py's _launch_algorithms [testing, CI] Remove linux hardcoding from daal4py's _launch_algorithms.py Oct 21, 2024
@icfaust icfaust changed the title [testing, CI] Remove linux hardcoding from daal4py's _launch_algorithms.py [testing] Remove linux hardcoding from daal4py's _launch_algorithms.py Oct 21, 2024
@icfaust icfaust marked this pull request as ready for review October 22, 2024 07:10
@Alexsandruss
Copy link
Contributor

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Oct 22, 2024

/intelci: run

@icfaust icfaust merged commit 2029a74 into uxlfoundation:main Oct 23, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants