Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Enable linear regression on GPU with non-PSD systems #2167

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

david-cortes-intel
Copy link
Contributor

@david-cortes-intel david-cortes-intel commented Nov 14, 2024

Description

As a follow up from oneDAL PR: uxlfoundation/oneDAL#2976

Once that PR gets merged, this PR adds support here for the new cases of linear regression on GPU that it enables.

Checks are expected to be failing at the moment as the PR hasn't been merged yet.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

Not applicable.

@icfaust
Copy link
Contributor

icfaust commented Nov 15, 2024

@david-cortes-intel Looks good to me, when the other PR is merged, we can rebase this check for green and merge. Just ping me.

@david-cortes-intel
Copy link
Contributor Author

Now waiting for the oneDAL version bump before this PR can be tested: uxlfoundation/oneDAL#2981

@david-cortes-intel david-cortes-intel changed the title [Draft] ENH: Enable linear regression on GPU with non-PSD systems ENH: Enable linear regression on GPU with non-PSD systems Nov 26, 2024
@david-cortes-intel
Copy link
Contributor Author

/intelci: run

@david-cortes-intel
Copy link
Contributor Author

/intelci: run

@david-cortes-intel david-cortes-intel marked this pull request as ready for review November 28, 2024 08:20
@david-cortes-intel
Copy link
Contributor Author

All CI jobs passing now.

@Alexsandruss Alexsandruss merged commit 488949e into uxlfoundation:main Nov 29, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gpu_interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants