-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Enable linear regression on GPU with non-PSD systems #2167
Merged
Alexsandruss
merged 5 commits into
uxlfoundation:main
from
david-cortes-intel:gpu_linreg_nonpsd
Nov 29, 2024
Merged
ENH: Enable linear regression on GPU with non-PSD systems #2167
Alexsandruss
merged 5 commits into
uxlfoundation:main
from
david-cortes-intel:gpu_linreg_nonpsd
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cortes-intel
requested review from
Alexsandruss,
samir-nasibli,
icfaust,
maria-Petrova,
napetrov and
emmwalsh
as code owners
November 14, 2024 11:30
@david-cortes-intel Looks good to me, when the other PR is merged, we can rebase this check for green and merge. Just ping me. |
13 tasks
Now waiting for the oneDAL version bump before this PR can be tested: uxlfoundation/oneDAL#2981 |
david-cortes-intel
changed the title
[Draft] ENH: Enable linear regression on GPU with non-PSD systems
ENH: Enable linear regression on GPU with non-PSD systems
Nov 26, 2024
/intelci: run |
/intelci: run |
All CI jobs passing now. |
Alexsandruss
approved these changes
Nov 29, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow up from oneDAL PR: uxlfoundation/oneDAL#2976
Once that PR gets merged, this PR adds support here for the new cases of linear regression on GPU that it enables.
Checks are expected to be failing at the moment as the PR hasn't been merged yet.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance
Not applicable.