Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] remove string comparison from data type oneDAL offload #2184

Merged
merged 13 commits into from
Nov 25, 2024

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Nov 23, 2024

Description

Use pybind11-native numpy intrinsics to understand whether to use float32 or float64. This removes ambiguity associated with the setting of the fptype attribute on python-side. For array-api support, we can switch away from setting a parameter on python side and look at the tables directly, or we can make oneDAL table objects and query their dtype. This would remove the need to propagate the array_namespace all they way back to the backend.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@icfaust
Copy link
Contributor Author

icfaust commented Nov 24, 2024

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Nov 25, 2024

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Nov 25, 2024

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Nov 25, 2024

/intelci: run

@icfaust icfaust added the enhancement New feature or request label Nov 25, 2024
@icfaust icfaust marked this pull request as ready for review November 25, 2024 10:35
@Alexsandruss Alexsandruss merged commit 8bc9ca0 into uxlfoundation:main Nov 25, 2024
29 checks passed
@icfaust icfaust deleted the dev/fptype_clarity branch November 25, 2024 21:14
@samir-nasibli
Copy link
Contributor

The PR was merged after a single review cycle, just 12 hours after being marked ready for review. @Alexsandruss and @icfaust, could you explain the urgency behind merging this PR? Especially considering that the changes dependent on the discussion in this PR have not yet been implemented

@icfaust
Copy link
Contributor Author

icfaust commented Nov 26, 2024

The PR was merged after a single review cycle, just 12 hours after being marked ready for review. @Alexsandruss and @icfaust, could you explain the urgency behind merging this PR? Especially considering that the changes dependent on the discussion in this PR have not yet been implemented

@samir-nasibli I did not communicate with Alexsandruss, the merge was done by him. We can continue to have discussions about it. I would like to hear your argument as to this and 2172.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants