-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] remove string comparison from data type oneDAL offload #2184
Conversation
/intelci: run |
/intelci: run |
/intelci: run |
/intelci: run |
The PR was merged after a single review cycle, just 12 hours after being marked ready for review. @Alexsandruss and @icfaust, could you explain the urgency behind merging this PR? Especially considering that the changes dependent on the discussion in this PR have not yet been implemented |
@samir-nasibli I did not communicate with Alexsandruss, the merge was done by him. We can continue to have discussions about it. I would like to hear your argument as to this and 2172. |
Description
Use pybind11-native numpy intrinsics to understand whether to use float32 or float64. This removes ambiguity associated with the setting of the fptype attribute on python-side. For array-api support, we can switch away from setting a parameter on python side and look at the tables directly, or we can make oneDAL table objects and query their dtype. This would remove the need to propagate the array_namespace all they way back to the backend.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance