Skip to content

Merge branch 'mjunix-small-fixes' #1035

Merge branch 'mjunix-small-fixes'

Merge branch 'mjunix-small-fixes' #1035

Triggered via push August 1, 2023 21:50
Status Success
Total duration 13m 38s
Artifacts 3

reko.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

34 warnings
build (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (ubuntu-latest): src/Decompiler/Scanning/FetFinder.cs#L53
The field 'FetFinder.uAddrMin' is never used
build (ubuntu-latest): src/Decompiler/Scanning/FetFinder.cs#L52
The field 'FetFinder.uAddrMax' is never used
build (ubuntu-latest): src/Gui/AddressSearchResult.cs#L112
Possible null reference argument for parameter 'item' in 'int AddressSearchResult.SelectBgColor(ImageMapItem item)'.
build (ubuntu-latest): src/UserInterfaces/AvaloniaUI/Views/ProcedureDialog.axaml.cs#L46
Nullability of reference types in type of parameter 'value' of 'void ProcedureDialog.Text.set' doesn't match implicitly implemented member 'void IDialog.Text.set' (possibly because of nullability attributes).
build (ubuntu-latest): src/UserInterfaces/AvaloniaUI/ViewModels/DecompilerMenus.cs#L103
Possible null reference argument for parameter 'key' in 'void MenuSystem.AddBinding(string windowKey, Guid cmdSet, int id, string key, KeyModifiers modifiers)'.
build (ubuntu-latest): src/UserInterfaces/AvaloniaUI/Controls/HexViewer2.axaml.cs#L19
Non-nullable event 'ScrollInvalidated' must contain a non-null value when exiting constructor. Consider declaring the event as nullable.
build (ubuntu-latest): src/UserInterfaces/AvaloniaUI/ViewModels/MenuStatusSetter.cs#L76
Possible null reference argument for parameter 'text' in 'void IMenuAdapter.SetText(int i, string text)'.
build (ubuntu-latest): src/UserInterfaces/AvaloniaUI/Services/AvaloniaEventListener.cs#L48
Non-nullable field 'cancellationSvc' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
build (ubuntu-latest): src/UserInterfaces/AvaloniaUI/Services/AvaloniaEventListener.cs#L77
Possible null reference argument for parameter 'addrVector' in 'JumpVectorNavigator.JumpVectorNavigator(IReadOnlyProgram program, IProcessorArchitecture arch, Address addrInstr, Address addrVector, int stride, IServiceProvider services)'.
build (macos-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (macos-latest): src/Decompiler/Scanning/FetFinder.cs#L53
The field 'FetFinder.uAddrMin' is never used
build (macos-latest): src/Decompiler/Scanning/FetFinder.cs#L52
The field 'FetFinder.uAddrMax' is never used
build (macos-latest): src/Gui/AddressSearchResult.cs#L112
Possible null reference argument for parameter 'item' in 'int AddressSearchResult.SelectBgColor(ImageMapItem item)'.
build (macos-latest): src/Environments/C64/C64BasicRewriter.cs#L552
'RtlEmitter.If(Expression, RtlInstruction)' is obsolete: 'RtlIf is going away soon: don't use it.'
build (macos-latest): src/ImageLoaders/XexLoader/XexLoader.cs#L192
'Rijndael' is obsolete: 'The Rijndael and RijndaelManaged types are obsolete. Use Aes instead.'
build (macos-latest): src/ImageLoaders/XexLoader/XexLoader.cs#L192
'RijndaelManaged' is obsolete: 'The Rijndael and RijndaelManaged types are obsolete. Use Aes instead.'
build (macos-latest): src/ImageLoaders/XexLoader/XexLoader.cs#L212
'RijndaelManaged' is obsolete: 'The Rijndael and RijndaelManaged types are obsolete. Use Aes instead.'
build (macos-latest): src/ImageLoaders/XexLoader/XexLoader.cs#L265
'RijndaelManaged' is obsolete: 'The Rijndael and RijndaelManaged types are obsolete. Use Aes instead.'
build (macos-latest): src/ImageLoaders/XexLoader/XexLoader.cs#L483
'RijndaelManaged' is obsolete: 'The Rijndael and RijndaelManaged types are obsolete. Use Aes instead.'
build (windows-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (windows-latest): src/Decompiler/Scanning/FetFinder.cs#L53
The field 'FetFinder.uAddrMin' is never used
build (windows-latest): src/Decompiler/Scanning/FetFinder.cs#L52
The field 'FetFinder.uAddrMax' is never used
build (windows-latest): src/Gui/AddressSearchResult.cs#L112
Possible null reference argument for parameter 'item' in 'int AddressSearchResult.SelectBgColor(ImageMapItem item)'.
build (windows-latest): src/UiPrototype/WinForms/MainForm.cs#L76
This call site is reachable on all platforms. 'Font' is only supported on: 'windows'.
build (windows-latest): src/UiPrototype/WinForms/MainForm.cs#L77
This call site is reachable on all platforms. 'FontStyle.Bold' is only supported on: 'windows'.
build (windows-latest): src/Environments/C64/C64BasicRewriter.cs#L552
'RtlEmitter.If(Expression, RtlInstruction)' is obsolete: 'RtlIf is going away soon: don't use it.'
build (windows-latest): src/UserInterfaces/WindowsForms/Forms/OpenAsDialog.cs#L61
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
build (windows-latest): src/UserInterfaces/WindowsForms/WindowsFormsDialogFactory.cs#L107
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
build (windows-latest): src/UserInterfaces/WindowsForms/Controls/MemoryControl.cs#L73
Field 'MemoryControl.yTopRow' is never assigned to, and will always have its default value 0
build (windows-latest): src/UserInterfaces/WindowsForms/Forms/ProcedureListPanel.Designer.cs#L147
The field 'ProcedureListPanel.label1' is never used
build (windows-latest): src/Installers/WixInstaller/Product.wxs#L63
ICE69: Mismatched component reference. Entry 'ApplicationStartMenuShortcut' of the Shortcut table belongs to component 'ApplicationShortcut'. However, the formatted string in column 'Target' references file 'WindowsDecompiler.exe' which belongs to component 'ProductComponent'. Components are in the same feature.

Artifacts

Produced during runtime
Name Size
reko-macos-latest Expired
32.5 MB
reko-ubuntu-latest Expired
32.6 MB
reko-windows-latest Expired
73 MB