forked from supabase/auth
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: clean up test setup in MFA tests (supabase#1452)
## What kind of change does this PR introduce? Remove redundant test setup, particularly around `TestSecondarySession`. - Changes `generateToken` into `generateAAL1Token` - Abstracts adding the claim and reloading a session into a single method. Was probably a mistake to add [AMREntry](https://github.com/supabase/gotrue/blob/e9f38e76d8a7b93c5c2bb0de918a9b156155f018/internal/models/sessions.go#L38). Should sync to use [AMRClaim](https://github.com/supabase/gotrue/blob/e9f38e76d8a7b93c5c2bb0de918a9b156155f018/internal/models/amr.go) at some point - Add additional check that a provider fields must exist if there's an SSO Claim on the last entry --------- Co-authored-by: joel <joel@joels-MacBook-Pro.local>
Showing
2 changed files
with
66 additions
and
75 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters