Use date arithmetic to allow dates with times other than 00:00:00 #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of directly comparing date values using valueOf, dates are now compared by making sure the dates and times fall under the same date. This fixes bugs for times other than 00:00:00 when setting the date.
Added a test to ensure that dates with times other than 00:00:00 are selected and stored properly.
|
@Azaret What do you think? Fix looks good enough to me as a temp fix until we support time picking! |
|
Looks good to me! |
|
Thanks @colavitam |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of directly comparing date values using valueOf, dates are now compared with arithmetic to check if they fall under the same date. This fixes resolves #1221, allowing for times other than 00:00:00 when setting the date.