Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring timedelta aliases (dateAliases) #1965

Merged
merged 1 commit into from
Aug 4, 2016
Merged

Refactoring timedelta aliases (dateAliases) #1965

merged 1 commit into from
Aug 4, 2016

Conversation

vsn4ik
Copy link
Member

@vsn4ik vsn4ik commented Aug 3, 2016 •
edited
Loading

Remove copypasta (eddd51d) and add tests.

First, let's merge #1910. Then I'm doing here rebase.

@vsn4ik vsn4ik changed the title Refactoring dateAliases Refactoring timedelta aliases (dateAliases) Aug 3, 2016
@acrobat
Copy link
Member

acrobat commented Aug 4, 2016

@vsn4ik can you rebase the branch? PR is ready for merge after!

@acrobat acrobat added this to the 1.7.0 milestone Aug 4, 2016
@vsn4ik
Copy link
Member Author

vsn4ik commented Aug 4, 2016

@acrobat Done!

@acrobat
Copy link
Member

acrobat commented Aug 4, 2016

Thanks @vsn4ik

@acrobat acrobat merged commit c9c1a86 into uxsolutions:master Aug 4, 2016
@vsn4ik vsn4ik deleted the refactoring-aliases-js branch August 4, 2016 19:43
@acrobat acrobat mentioned this pull request May 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vsn4ik @acrobat