Allow customizing day cell value #2043

programcsharp · 2016-10-24T02:06:17Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
License	MIT

Azaret

Hi, Thank you for your work. Please don't forget to add some unit tests.

Azaret · 2016-10-25T17:18:51Z

js/bootstrap-datepicker.js

@@ -1196,6 +1200,10 @@
 			}

 			if (!target.hasClass('disabled')){
+				// Allow clicking on elements inside a day
+				if (target.parent().hasClass('day'))
+			        target = target.parent();


Since you allow html, you code won't work if I send <div><div></div></div>, you should change e.target by e.currentTarget, but then you should do a full test to be sure it does not break everything.

I'm not sure that e.currentTarget would work because bubbling/propagation are stopped at the top of the click handler.

Instead, I use .parents(), does that work?

It should I guess

Azaret · 2016-10-25T17:28:58Z

js/bootstrap-datepicker.js

@@ -1041,7 +1045,7 @@
 					clsName = $.unique(clsName);
 				}

-				html.push('<td class="'+clsName.join(' ')+'"' + (tooltip ? ' title="'+tooltip+'"' : '') + (this.o.dateCells ? ' data-date="'+(prevMonth.getTime().toString())+'"' : '') + '>'+prevMonth.getUTCDate() + '</td>');
+				html.push('<td class="'+clsName.join(' ')+'"' + (tooltip ? ' title="'+tooltip+'"' : '') + (this.o.dateCells ? ' data-date="'+(prevMonth.getTime().toString())+'"' : '') + '>' + displayDate + '</td>');


You are actually making the other views sad and envious to the monthView :)
May you add this on the other views please ?

Azaret · 2016-10-25T17:30:58Z

js/bootstrap-datepicker.js

@@ -1017,6 +1017,8 @@
 				clsName = this.getClassNames(prevMonth);
 				clsName.push('day');

+				var displayDate = prevMonth.getUTCDate();


Since other tickets like #2037 would like such PR, I think a more abstract name for this option should be use, like content. Do you guys agree @acrobat @vsn4ik @hebbet ?

Add test for content

Add test to check click on custom content

programcsharp · 2016-10-28T00:19:28Z

Changed option name to content
Changed click handler to use .parents() to find .day
Added generic test for content
Added test for clicking inside nested content

Anything else need done here?

acrobat · 2016-10-28T12:32:17Z

js/bootstrap-datepicker.js

@@ -1196,6 +1200,12 @@
 			}

 			if (!target.hasClass('disabled')){
+				// Allow clicking on elements inside a day
+				var day = target.parents('.day');


Day is already defined on line 1183, see travis build

Azaret · 2016-10-28T13:58:30Z

Yeah, I would like to see the same feature for the others views (month, year, decade, ...) lookup for beforeShowMonth for month and callback inside _fill_yearsView() for others.
Ty

programcsharp · 2016-10-28T14:33:03Z

OK, I can do that for consistency and all that goodness. I'll fix the var name too.

Do you have a better suggestion for how to handle deeply nested clicks? I can duplicate the same thing I did for day -- target.parents(".day, .month, .year"), but that just seems non-optimal.

Azaret · 2016-10-28T15:11:09Z

Do it for the fame ;)

target.closest() should be better performance wise I think, since it will stop at the first parent match.
It should be enough for now, we might break the click function in the 2.x, since binding events directly to the actual td will be easier to manage than catching any click anywhere on the picker (which by the way is a broken way of doing things because it does trigger the show event at any clicks).

brandon-burciaga · 2016-11-23T22:18:48Z

Being able to customize content within each day would be really awesome. I am trying to display counts of something in each day but haven't been able to figure out how.

acrobat · 2017-01-09T19:09:51Z

@Azaret Can you review the pull request again? Thanks!

acrobat · 2017-02-02T13:23:23Z

@programcsharp I would like to get this PR finished and have it shipped with 1.7.0! 🚀 Do you need to do any work here? Please rebase the branch against the current mast and can you check the failing travis build? Thanks!

@Azaret Time for a last review? Thanks!

programcsharp · 2017-02-03T18:22:49Z

OK, lemme see what I can do here.

…epicker into custom-day-display # Conflicts: # js/bootstrap-datepicker.js

programcsharp · 2017-02-03T18:35:50Z

Fixed the dupe variable name issue @Azaret mentioned. Should be ready to go now.

I don't have time to add the month/year/decade/century implementations.

acrobat · 2017-02-06T18:15:57Z

Thanks @programcsharp! I will look into this to see what I can do to have this feature shipped with 1.7.0

Azaret · 2017-02-12T10:10:48Z

I guess we can push it in RC2 @acrobat

acrobat · 2017-02-12T11:44:50Z

@Azaret Yes I will merge this today and tag a new RC release. But we need to try to implement this feature for all beforeXxx methods, I hope to find some time for this!

acrobat · 2017-02-12T18:36:15Z

Thanks @programcsharp! The missing parts for beforeShowMonth (yeay, decade, etc) will be done in #2120

Allow customizing day cell value

e1dfbbd

Azaret requested changes Oct 25, 2016

View reviewed changes

Azaret added pr-needs-test pr-needs-review pr-needs-work release-1.7.0 labels Oct 25, 2016

Azaret added this to the 1.7.0 milestone Oct 25, 2016

programcsharp added 2 commits October 27, 2016 17:03

Change beforeShowDay option name to content

c5cafb5

Add test for content

Handle deeper nested content in day

c544da6

Add test to check click on custom content

acrobat reviewed Oct 28, 2016

View reviewed changes

Azaret mentioned this pull request Nov 5, 2016

Add Number in Each Day of DatePicker #2049

Open

programcsharp added 2 commits February 3, 2017 11:25

Merge branch 'master' of https://github.com/uxsolutions/bootstrap-dat…

601c6a6

…epicker into custom-day-display # Conflicts: # js/bootstrap-datepicker.js

Fix dupe variable name

77af1d0

Azaret approved these changes Feb 12, 2017

View reviewed changes

Merge branch 'master' into custom-day-display

a5db368

Azaret mentioned this pull request Feb 12, 2017

Expand customizable cells #2043 to all views #2120

Open

Merge branch 'master' into custom-day-display

8751c13

acrobat merged commit 3b1e472 into uxsolutions:master Feb 12, 2017

acrobat mentioned this pull request Feb 13, 2017

Append div to specific dates #2037

Closed

vsn4ik mentioned this pull request Feb 14, 2017

Fix beforeShowDay with content not equal number #2122

Merged

Azaret mentioned this pull request Feb 14, 2017

Expand customizable cells to all views #2124

Open

acrobat mentioned this pull request May 1, 2017

Release 1.7.0 #1748

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow customizing day cell value #2043

Allow customizing day cell value #2043

programcsharp commented Oct 24, 2016

Azaret left a comment

Azaret Oct 25, 2016

programcsharp Oct 28, 2016

Azaret Oct 28, 2016

Azaret Oct 25, 2016

Azaret Oct 25, 2016

acrobat Oct 26, 2016

programcsharp commented Oct 28, 2016

acrobat Oct 28, 2016

programcsharp Feb 3, 2017

Azaret commented Oct 28, 2016

programcsharp commented Oct 28, 2016

Azaret commented Oct 28, 2016

brandon-burciaga commented Nov 23, 2016

acrobat commented Jan 9, 2017

acrobat commented Feb 2, 2017

programcsharp commented Feb 3, 2017

programcsharp commented Feb 3, 2017

acrobat commented Feb 6, 2017

Azaret commented Feb 12, 2017

acrobat commented Feb 12, 2017

acrobat commented Feb 12, 2017

Allow customizing day cell value #2043

Allow customizing day cell value #2043

Conversation

programcsharp commented Oct 24, 2016

Azaret left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

programcsharp commented Oct 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Azaret commented Oct 28, 2016

programcsharp commented Oct 28, 2016

Azaret commented Oct 28, 2016

brandon-burciaga commented Nov 23, 2016

acrobat commented Jan 9, 2017

acrobat commented Feb 2, 2017

programcsharp commented Feb 3, 2017

programcsharp commented Feb 3, 2017

acrobat commented Feb 6, 2017

Azaret commented Feb 12, 2017

acrobat commented Feb 12, 2017

acrobat commented Feb 12, 2017