Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update grunt and other dev-dependencies #2111

Merged
merged 1 commit into from
Jan 24, 2017
Merged

update grunt and other dev-dependencies #2111

merged 1 commit into from
Jan 24, 2017

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Jan 24, 2017

Tests were hanging at

Running "qunit:main" (qunit) task
Testing tests/tests.html
and never finish. Updating dependencies fixed it for me.

My configuration:

$ nodejs -v
v6.9.4
$ npm -v
3.10.10
$ grunt --version
grunt-cli v1.2.0
grunt v0.4.5
Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets
License MIT

vsn4ik
vsn4ik reviewed Jan 24, 2017
View reviewed changes
package.json
"grunt-jscs": "^3.0.1",
"grunt-string-replace": "^1.3.1",
"load-grunt-tasks": "^3.5.2",
"phantomjs-prebuilt": "~2.1.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest is 2.1.14.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tilde range matches all higher patch version as well. ~2.1.7 matches 2.1.x if x is greater or equal 7.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~2.1.7 is ok for now. We can change it if we upgrade to a 2.x version

@acrobat
Copy link
Member

acrobat commented Jan 24, 2017

Thanks @jelhan! Btw are you interested in becoming a collaborator of bootstrap-datepicker and help us get this 1.x version stable (and maybe in the future start work on 2.0)? You've opened a few PR's and looks like you know your way around js!

@acrobat acrobat merged commit 7d17583 into uxsolutions:master Jan 24, 2017
@jelhan
Copy link
Contributor Author

jelhan commented Jan 24, 2017

@acrobat Thanks for the offer but I don't have much spare time these days.

@acrobat
Copy link
Member

acrobat commented Jan 24, 2017

No problem! Thanks for the contributions!

@acrobat acrobat mentioned this pull request May 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsn4ik vsn4ik vsn4ik left review comments

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jelhan @acrobat @vsn4ik