-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using a new user per feature, to facilitate parallelization of secondary_parallelizable.yml in CI #5743
Conversation
f8a3f80
to
4ebab75
Compare
faf6a4e
to
9353132
Compare
9353132
to
c60091a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see question, other than that lgtm
c60091a
to
94b357b
Compare
testsuite/features/secondary/buildhost_docker_build_image.feature
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues in the PR tests:
It seems this was from an old PR test run!
[2022-08-05T10:35:01.439Z] Scenario: Add a product and one of its modules # features/reposync/srv_sync_products.feature:36
[2022-08-05T10:35:01.439Z] This scenario ran at: 2022-08-05 12:34:35 +0200
[2022-08-05T10:35:01.439Z] When I follow the left menu "Admin > Setup Wizard > Products" # features/step_definitions/navigation_steps.rb:342
[2022-08-05T10:35:01.439Z] Unable to find xpath "//aside/div[@id='nav']/nav/ul/li/div/a[contains(.,'Admin')]/parent::div/parent::li" (Capybara::ElementNotFound)
[2022-08-05T10:35:01.439Z] ./features/step_definitions/navigation_steps.rb:361:in `block (2 levels) in <top (required)>'
[2022-08-05T10:35:01.439Z] ./features/step_definitions/navigation_steps.rb:355:in `each'
[2022-08-05T10:35:01.439Z] ./features/step_definitions/navigation_steps.rb:355:in `each_with_index'
[2022-08-05T10:35:01.439Z] ./features/step_definitions/navigation_steps.rb:355:in `/^I follow the left menu "([^"]*)"$/'
[2022-08-05T10:35:01.439Z] features/reposync/srv_sync_products.feature:37:in `I follow the left menu "Admin > Setup Wizard > Products"'
It could be that this scenario is not done with the admin user and therefore the scenario fails. This is also not the only scenario that failed with this regards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved it but am curious on how this has an impact on the performance. But let`s wait for Erics go/no go.
94b357b
to
488146f
Compare
488146f
to
afae980
Compare
It will for sure increase a bit the time per feature. |
afae980
to
d386401
Compare
Overall don't forget to update the copyright. |
446a35c
to
93a6ebf
Compare
Good point. Update: Done. |
…h qe-refactor-enabling-parallel-tests
93a6ebf
to
2eb65dc
Compare
…ary_parallelizable.yml in CI (#5743) * Using a new user per feature * Removing refactors made to enable parallel tests, moved to this branch qe-refactor-enabling-parallel-tests * Updating the Copyright year
…ary_parallelizable.yml in CI (#5743) * Using a new user per feature * Removing refactors made to enable parallel tests, moved to this branch qe-refactor-enabling-parallel-tests * Updating the Copyright year
…ary_parallelizable.yml in CI (#5743) * Using a new user per feature * Removing refactors made to enable parallel tests, moved to this branch qe-refactor-enabling-parallel-tests * Updating the Copyright year
…ary_parallelizable.yml in CI (#5743) * Using a new user per feature * Removing refactors made to enable parallel tests, moved to this branch qe-refactor-enabling-parallel-tests * Updating the Copyright year
…ary_parallelizable.yml in CI (#5743) * Using a new user per feature * Removing refactors made to enable parallel tests, moved to this branch qe-refactor-enabling-parallel-tests * Updating the Copyright year
…ary_parallelizable.yml in CI (#5743) * Using a new user per feature * Removing refactors made to enable parallel tests, moved to this branch qe-refactor-enabling-parallel-tests * Updating the Copyright year
…ary_parallelizable.yml in CI (#5743) * Using a new user per feature * Removing refactors made to enable parallel tests, moved to this branch qe-refactor-enabling-parallel-tests * Updating the Copyright year
…ary_parallelizable.yml in CI (#5743) * Using a new user per feature * Removing refactors made to enable parallel tests, moved to this branch qe-refactor-enabling-parallel-tests * Updating the Copyright year
…ary_parallelizable.yml in CI (#5743) * Using a new user per feature * Removing refactors made to enable parallel tests, moved to this branch qe-refactor-enabling-parallel-tests * Updating the Copyright year
What does this PR change?
Related to https://github.com/SUSE/spacewalk/issues/9748
Creating a new user per feature, using a scenario hook that will only pass for the first scenario per feature, acting as a feature hook.
It will by-pass the authentication of testing or admin users, using the regular step, when the feature variable @username is not null.
It creates a user name based on the feature filename because the feature name is too long and we have secondary features that acts on several clients during the same feature, so client name can't be use for that purpose on regular CI Tests.
How to debug parallel tests is another topic, that we can discuss and improve separetely.
The aime of that PR is only to fix the current issue with multiple systems selected as described in the issue linked.
GUI diff
No difference.
Documentation
No documentation needed
DONE
Test coverage
Cucumber tests were changed, need to check on CI
DONE
Links
None
Changelogs
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: