Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QE: Add smoke tests for Grafana in BV #6170

Merged
merged 1 commit into from
Dec 21, 2022
Merged

QE: Add smoke tests for Grafana in BV #6170

merged 1 commit into from
Dec 21, 2022

Conversation

vandabarata
Copy link
Contributor

@vandabarata vandabarata commented Nov 17, 2022 •
edited
Loading

What does this PR change?

Adds tests in the BV testsuite for the Grafana formula

  • Use monitoring_server as monitoring server (for Prometheus and Grafana)
  • Access the grafana endpoint to make sure Grafana is working
  • Open Grafana and confirm the 4 expected default dashboards are listed

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Cucumber tests were added for BV teststuite

  • DONE

Links

Closes https://github.com/SUSE/spacewalk/issues/17627
Ports:

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests" (Test skipped, there are no changes to test)
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@vandabarata vandabarata self-assigned this Nov 17, 2022
Bischoff
Bischoff requested changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nitpickings

testsuite/features/build_validation/smoke_tests/smoke_tests.template Outdated Show resolved Hide resolved
testsuite/features/build_validation/smoke_tests/smoke_tests.template Outdated Show resolved Hide resolved
testsuite/features/step_definitions/navigation_steps.rb Show resolved Hide resolved
@srbarrios
Copy link
Member

srbarrios commented Nov 18, 2022 •
edited
Loading

I think that's not the correct approach sorry.

I think we need to have as infrastructure:

  • SUSE Manager Server
  • SUSE Manager Proxy
  • Monitoring Server (must have Prometheus and Grafana salt formulas)
  • All our minions (must have the Prometheus Exporter salt formula)

We first prepare a SUSE minion that will act as our Monitoring server, applying the prometheus and grafana formulas.

Then we test every , by applying the Prometheus exporter formula and checking that the entry of this minion is available in the dashboard from the monitoring server.

In addition, but a different scenario, we should also check in all our suse minions, if the Prometheus and Grafana salt formulas can work on them, applying it, and visiting the dashboards. maybe just checking that the checkbox is available for now.

@vandabarata
Copy link
Contributor Author

vandabarata commented Nov 18, 2022 •
edited
Loading

I think that's not the correct approach sorry.

I think we need to have as infrastructure:

  • SUSE Manager Server
  • SUSE Manager Proxy
  • Monitoring Server (must have Prometheus and Grafana salt formulas)
  • All our minions (must have the Prometheus Exporter salt formula)

We first prepare a SUSE minion that will act as our Monitoring server, applying the prometheus and grafana formulas.

Then we test every , by applying the Prometheus exporter formula and checking that the entry of this minion is available in the dashboard from the monitoring server.

In addition, but a different scenario, we should also check in all our suse minions, if the Prometheus and Grafana salt formulas can work on them, applying it, and visiting the dashboards.

@srbarrios that's all fine by me but how do we put that into effect? I'm afraid I'm new to the BV infra and would probably need help setting up our additional monitoring server

@vandabarata vandabarata force-pushed the qe-grafana-tests-bv branch 2 times, most recently from afc7f2d to bb125b4 Compare November 28, 2022 15:08
@vandabarata

This comment was marked as outdated.

Sign in to view
Bischoff
Bischoff approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see requested nitpicks, otherwise lgtm

testsuite/documentation/cucumber-steps.md Outdated Show resolved Hide resolved
testsuite/documentation/cucumber-steps.md Outdated Show resolved Hide resolved
testsuite/features/build_validation/core/allcli_sanity.feature Outdated Show resolved Hide resolved
testsuite/features/build_validation/init_clients/monitoring_server.feature Outdated Show resolved Hide resolved
testsuite/features/build_validation/init_clients/monitoring_server.feature Outdated Show resolved Hide resolved
testsuite/features/build_validation/init_clients/monitoring_server.feature Outdated Show resolved Hide resolved
testsuite/features/support/twopence_init.rb Outdated Show resolved Hide resolved
@vandabarata vandabarata marked this pull request as ready for review December 21, 2022 10:15
@vandabarata vandabarata requested a review from a team as a code owner December 21, 2022 10:15
nodeg
nodeg approved these changes Dec 21, 2022
View reviewed changes
testsuite/features/support/twopence_init.rb
@@ -72,6 +72,7 @@ def twopence_init(target)
$opensuse154arm_ssh_minion = twopence_init("ssh:#{ENV['OPENSUSE154ARM_SSHMINION']}") if ENV['OPENSUSE154ARM_SSHMINION']
$sle12sp5_buildhost = twopence_init("ssh:#{ENV['SLE12SP5_BUILDHOST']}") if ENV['SLE12SP5_BUILDHOST']
$sle15sp4_buildhost = twopence_init("ssh:#{ENV['SLE15SP4_BUILDHOST']}") if ENV['SLE15SP4_BUILDHOST']
$monitoring_server = twopence_init("ssh:#{ENV['MONITORING_SERVER']}") if ENV['MONITORING_SERVER']
Copy link
Member

@nodeg nodeg Dec 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you already adjust the .bashrc on the controller in sumaform and added those environment variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bischoff did! uyuni-project/sumaform#1223

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. All good then 😉

@vandabarata vandabarata merged commit a7059f7 into uyuni-project:master Dec 21, 2022
@vandabarata vandabarata deleted the qe-grafana-tests-bv branch December 21, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srbarrios srbarrios srbarrios approved these changes

@nodeg nodeg nodeg approved these changes

@Bischoff Bischoff Bischoff approved these changes

Assignees

@vandabarata vandabarata

Labels
build-validation-features ci-pipelines ruby_rubocop test-framework testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vandabarata @srbarrios @Bischoff @nodeg