-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QE: Adapt BV test suite code for Uyuni BV #7032
Conversation
9a0030d
to
2052097
Compare
aaac387
to
881bcc9
Compare
3682a6c
to
2d9db24
Compare
4f53703
to
e46c011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
...s/build_validation/add_non_MU_repositories/ubuntu1804_minion_add_common_repositories.feature
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the commit to remove Ubuntu 18.04 from this PR.
This is out of scope, and already covered by #7398
testsuite/features/build_validation/add_non_MU_repositories/alma9_minion_build_clm.feature
Outdated
Show resolved
Hide resolved
This adds the ability to reload systemd services which will only reload their configuration. Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
Rebase done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more nitpick and we're good
The old array syntax work as expected: When(/^I execute doms test for "([^"]*)"$/) do |client|
base_channel = BASE_CHANNEL_BY_CLIENT[product][client]
channel = CHANNEL_TO_SYNC_BY_BASE_CHANNEL[product][base_channel]
parent_channel = PARENT_CHANNEL_TO_SYNC_BY_BASE_CHANNEL[product][base_channel]
puts base_channel
puts channel
puts parent_channel # <--- nil in our case
end Feature: doms test
Scenario: Test new constant # features/dom.feature:6
This scenario ran at: 2023-08-29 09:24:56 +0200
openSUSE Leap 15.4 (x86_64)
openSUSE-Leap-15.4-x86_64-uyuni
When I execute doms test for "proxy" # features/step_definitions/common_steps.rb:536
This scenario took: 1 seconds
1 scenario (1 passed)
1 step (1 passed)
0m0.849s |
testsuite/features/build_validation/add_non_MU_repositories/alma9_minion_build_clm.feature
Outdated
Show resolved
Hide resolved
Now I got it. Makes sense, I will adjust the code. |
Waiting for the GitHub Actions before merging. |
This will adjust the build validation test suite code for Uyuni. Major differences compared to SUMA: - Adding products via `spacewalk-common-channels` - Different channel names - no Liberty Linux 9 support Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
What does this PR change?
This will
systemctl reload
stepGUI diff
No difference.
Documentation
Test coverage
Links
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: