Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QE: Adapt BV test suite code for Uyuni BV #7032

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

nodeg
Copy link
Member

@nodeg nodeg commented May 17, 2023

What does this PR change?

This will

  • adapt our BV test suite code for the Uyuni BV
  • add verbosity to service restart commands
  • add systemctl reload step

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes
  • DONE

Test coverage

  • Cucumber tests were edited
  • DONE

Links

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@nodeg nodeg self-assigned this May 17, 2023
@nodeg nodeg force-pushed the qe-uyuni-bv branch 2 times, most recently from 9a0030d to 2052097 Compare May 23, 2023 12:36
@nodeg nodeg force-pushed the qe-uyuni-bv branch 9 times, most recently from aaac387 to 881bcc9 Compare August 9, 2023 06:19
@nodeg nodeg force-pushed the qe-uyuni-bv branch 6 times, most recently from 3682a6c to 2d9db24 Compare August 11, 2023 08:00
@nodeg nodeg force-pushed the qe-uyuni-bv branch 2 times, most recently from 4f53703 to e46c011 Compare August 11, 2023 11:15
@nodeg nodeg requested a review from a team as a code owner August 28, 2023 12:22
@nodeg nodeg requested a review from srbarrios August 28, 2023 12:25
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

testsuite/documentation/cucumber-steps.md Outdated Show resolved Hide resolved
testsuite/features/step_definitions/api_common.rb Outdated Show resolved Hide resolved
testsuite/features/support/commonlib.rb Outdated Show resolved Hide resolved
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the commit to remove Ubuntu 18.04 from this PR.
This is out of scope, and already covered by #7398

nodeg added 2 commits August 28, 2023 15:54
This adds the ability to reload systemd services which will only reload
their configuration.

Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
@nodeg
Copy link
Member Author

nodeg commented Aug 28, 2023

Rebase done.

@nodeg
Copy link
Member Author

nodeg commented Aug 28, 2023

The failed test is a flaky one.
image

@nodeg nodeg requested review from srbarrios and Bischoff August 29, 2023 07:28
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more nitpick and we're good

testsuite/documentation/cucumber-steps.md Outdated Show resolved Hide resolved
@nodeg
Copy link
Member Author

nodeg commented Aug 29, 2023

The old array syntax work as expected:

When(/^I execute doms test for "([^"]*)"$/) do |client|
 base_channel = BASE_CHANNEL_BY_CLIENT[product][client]
 channel = CHANNEL_TO_SYNC_BY_BASE_CHANNEL[product][base_channel]
 parent_channel = PARENT_CHANNEL_TO_SYNC_BY_BASE_CHANNEL[product][base_channel]
 puts base_channel
 puts channel
 puts parent_channel # <--- nil in our case
end
Feature: doms test

  Scenario: Test new constant            # features/dom.feature:6
      This scenario ran at: 2023-08-29 09:24:56 +0200
openSUSE Leap 15.4 (x86_64)
openSUSE-Leap-15.4-x86_64-uyuni

    When I execute doms test for "proxy" # features/step_definitions/common_steps.rb:536
      This scenario took: 1 seconds

1 scenario (1 passed)
1 step (1 passed)
0m0.849s

@nodeg
Copy link
Member Author

nodeg commented Aug 29, 2023

Yes, what I mean is that if there is only one entry "Uyuni Client Tools for AlmaLinux 9 (x86_64) (Development)" and there is no entry "Uyuni Client Tools for AlmaLinux 9 (x86_64)" for now. I think we better use "Uyuni Client Tools for AlmaLinux 9 (x86_64)" on this step, as this will select the same entry with or without this word appended, and once SCC change the sub-product name to "Uyuni Client Tools for AlmaLinux 9 (x86_64)" we will not need to update our code to adapt to it.

Now I got it. Makes sense, I will adjust the code.

@nodeg nodeg requested a review from srbarrios August 29, 2023 08:00
@nodeg
Copy link
Member Author

nodeg commented Aug 29, 2023

Waiting for the GitHub Actions before merging.

@nodeg
Copy link
Member Author

nodeg commented Aug 29, 2023

Test are all good. I will squash some of the temporary commits and will directly merge after this.
image

This will adjust the build validation test suite code for Uyuni.

Major differences compared to SUMA:

- Adding products via `spacewalk-common-channels`
- Different channel names
- no Liberty Linux 9 support

Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
@nodeg nodeg merged commit 4d54eb1 into uyuni-project:master Aug 29, 2023
@nodeg nodeg deleted the qe-uyuni-bv branch August 29, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants