Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scenario to ensure that uptodate state works properly on recurring actions #7291

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Add scenario to ensure that uptodate state works properly on recurring actions #7291

merged 1 commit into from
Sep 29, 2023

Conversation

wweellddeerr
Copy link
Contributor

What does this PR change?

See title.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: testsuite

  • DONE

Test coverage

  • Cucumber tests were added

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/21488

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@cbbayburt
Copy link
Contributor

@ktsamis FYI

@wweellddeerr wweellddeerr changed the title Add scenario to assure that uptodate state works properly on recurring actions Add scenario to ensure that uptodate state works properly on recurring actions Sep 1, 2023
@wweellddeerr wweellddeerr marked this pull request as ready for review September 1, 2023 13:51
@wweellddeerr wweellddeerr requested a review from a team as a code owner September 1, 2023 13:51
@wweellddeerr wweellddeerr requested a review from ktsamis September 1, 2023 13:54
srbarrios
srbarrios approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@srbarrios srbarrios left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (aside my small remark)
But please before merging it, be sure the test pass in the Pull Request tests: https://ci.suse.de/view/Manager/view/Uyuni-PRs/job/uyuni-prs-ci-tests/

@wweellddeerr wweellddeerr force-pushed the test-uptodate branch 3 times, most recently from e8d0750 to 24469bb Compare September 12, 2023 10:04
cbbayburt
cbbayburt approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@cbbayburt cbbayburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks, @wweellddeerr

@wweellddeerr
Copy link
Contributor Author

The test passed on Jenkins, so I'm going to merge this PR.

@wweellddeerr wweellddeerr merged commit c275e8e into uyuni-project:master Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbbayburt cbbayburt cbbayburt approved these changes

@srbarrios srbarrios srbarrios approved these changes

@ktsamis ktsamis Awaiting requested review from ktsamis

Assignees
No one assigned
Labels
ruby_rubocop secondary-features test-framework testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wweellddeerr @cbbayburt @srbarrios