Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SCC REST call to register systems in bulk #7559

Merged
merged 8 commits into from
Oct 2, 2023

Conversation

rjpmestre
Copy link
Contributor

@rjpmestre rjpmestre commented Sep 18, 2023

What does this PR change?

Update the current SCC system registration mechanism. Currently, it uses a SCC REST service that registers one system at a time. We are replacing it with a more efficient service that can handle bulk registrations.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed

  • DONE

Test coverage

  • Unit tests were added

  • DONE

Links

Implements https://github.com/SUSE/spacewalk/issues/17456

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@rjpmestre rjpmestre requested a review from a team as a code owner September 18, 2023 13:41
@rjpmestre rjpmestre requested review from parlt91 and removed request for a team September 18, 2023 13:41
@github-actions
Copy link
Contributor

Suggested tests to cover this Pull Request
  • allcli_sanity
  • srv_sync_channels
  • srv_disable_local_repos_off

Copy link
Contributor

@parlt91 parlt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good to me. However I am not familiar with SCC system registration at all. So I'd advise a second review from someone who knows the code better.

Also there is some failing acceptance tests related to removing system groups. Not sure if they are related but they could be. Please have a look before I approve.

Also your most recent changes seem to have broken your added java tests

@admd admd requested a review from mcalmer September 19, 2023 09:53
rjpmestre and others added 2 commits September 20, 2023 09:41
@cbosdo cbosdo added the ready PR ready, waiting branch is unlocked label Sep 26, 2023
@rjpmestre rjpmestre self-assigned this Sep 27, 2023
@rjpmestre rjpmestre merged commit 4051dc2 into uyuni-project:master Oct 2, 2023
15 checks passed
@rjpmestre rjpmestre deleted the bulk_scc_system_register branch December 18, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants