-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SCC REST call to register systems in bulk #7559
Update SCC REST call to register systems in bulk #7559
Conversation
Suggested tests to cover this Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself looks good to me. However I am not familiar with SCC system registration at all. So I'd advise a second review from someone who knows the code better.
Also there is some failing acceptance tests related to removing system groups. Not sure if they are related but they could be. Please have a look before I approve.
Also your most recent changes seem to have broken your added java tests
java/code/src/com/suse/scc/model/SCCOrganizationSystemsUpdateResponse.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Calmer <Michael.Calmer@suse.de>
What does this PR change?
Update the current SCC system registration mechanism. Currently, it uses a SCC REST service that registers one system at a time. We are replacing it with a more efficient service that can handle bulk registrations.
GUI diff
No difference.
Documentation
No documentation needed
DONE
Test coverage
Unit tests were added
DONE
Links
Implements https://github.com/SUSE/spacewalk/issues/17456
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: