Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine the paths when they collide #7585

Merged

Conversation

mackdk
Copy link
Contributor

@mackdk mackdk commented Sep 26, 2023

What does this PR change?

This PR changes how the paths from the credentials and from the repository are combined for PAYG. When the path collides in fact now we are generated the wrong path. This change ensure we do not duplicate the overlapping folders in the final url.

Port of https://github.com/SUSE/spacewalk/pull/22578

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Unit tests were added

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/22552
Tracks https://github.com/SUSE/spacewalk/pull/22578

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@github-actions
Copy link
Contributor

Suggested tests to cover this Pull Request
  • srv_rename_hostname
  • allcli_sanity
  • srv_monitoring
  • proxy_branch_network
  • proxy_cobbler_pxeboot

@mackdk mackdk marked this pull request as ready for review September 26, 2023 12:21
@mackdk mackdk requested a review from a team as a code owner September 26, 2023 12:21
@mackdk mackdk requested review from wweellddeerr and removed request for a team September 26, 2023 12:21
@mackdk mackdk force-pushed the payg-combine-clashing-path branch from c496fa2 to 21669cc Compare October 2, 2023 13:25
@mackdk mackdk changed the base branch from master to payg-latest-changes October 2, 2023 13:25
@mackdk mackdk removed the request for review from wweellddeerr October 2, 2023 13:25
@mackdk mackdk merged commit 152b47d into uyuni-project:payg-latest-changes Oct 2, 2023
11 checks passed
@mackdk mackdk deleted the payg-combine-clashing-path branch October 2, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant